summaryrefslogtreecommitdiffstats
path: root/pkg
diff options
context:
space:
mode:
authorJesse Duffield <jessedduffield@gmail.com>2024-01-30 08:49:36 +1100
committerGitHub <noreply@github.com>2024-01-30 08:49:36 +1100
commit761c77f5a278c998afe8ca5c34e1b832185d6b3b (patch)
treec7df3e49032165278f4e73f0536298b0df8f0170 /pkg
parent9d840088ace91bce355d0542a8a189f9e77e07ec (diff)
parentf9e842806147a38acbd92ebf8dd84a1ef7e57e81 (diff)
Use slimmer scrollbars (#3283)
(hopefully) fixes https://github.com/jesseduffield/lazygit/issues/1924 The previous scrollbars were too chunky and encroached too much on a view's content. The new ones are slim and right-aligned so they encroach into dead space between views which is much better. Before: ![image](https://github.com/jesseduffield/lazygit/assets/8456633/fe125804-0cb8-4f9b-be4c-5710fd73ac14) After: ![image](https://github.com/jesseduffield/lazygit/assets/8456633/8ae18f96-e2fd-46ff-be9a-09e745da1177) Admittedly, the original scrollbars look more like typical scrollbars and do a better job at telling you where the start and end of the scrollbar is. We experimented with having special characters for scrollbar bounds in the slim version but it all looked pretty ugly, and there's just not many ascii characters to choose from. Based on gocui PR: https://github.com/jesseduffield/gocui/pull/45 The important changes are in vendor/github.com/jesseduffield/gocui/gui.go vendor/github.com/jesseduffield/gocui/scrollbar.go The other changes are just modules being updated. - **PR Description** - **Please check if the PR fulfills these requirements** * [x] Cheatsheets are up-to-date (run `go generate ./...`) * [x] Code has been formatted (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#code-formatting)) * [x] Tests have been added/updated (see [here](https://github.com/jesseduffield/lazygit/blob/master/pkg/integration/README.md) for the integration test guide) * [x] Text is internationalised (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#internationalisation)) * [x] Docs (specifically `docs/Config.md`) have been updated if necessary * [x] You've read through your own file changes for silly mistakes etc <!-- Be sure to name your PR with an imperative e.g. 'Add worktrees view' see https://github.com/jesseduffield/lazygit/releases/tag/v0.40.0 for examples -->
Diffstat (limited to 'pkg')
0 files changed, 0 insertions, 0 deletions