diff options
author | Stefan Haller <stefan@haller-berlin.de> | 2024-06-23 12:56:08 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-23 12:56:08 +0200 |
commit | a62a5089d6ed5ba989279590a5bd3426829c856d (patch) | |
tree | f5a601c67bb48a1da748d46cbf2216fedbe22e89 /pkg/utils/formatting.go | |
parent | a5620ebe3a9665908d39a2e668589b2c8a2e8112 (diff) | |
parent | 4967e5136e641bfc2bdb3eaa3ca0bd81ba68878f (diff) |
Show current value in menus (#3628)
- **PR Description**
Some of our menus let you pick a value for some option (e.g. the sort
order menus for branches and commits). It's nice to see which one is the
current value when opening such a menu, so this PR implements that.
For menus that also have key bindings, the radio button goes between the
key and the label.
As an alternative, I considered selecting the current value when the
menu is opened; however, we currently have no menus where we select a
different entry than the first one, and it might be confusing for people
who are used to opening a menu and then pressing down-arrow a certain
number of times to get to a particular value.
- **Please check if the PR fulfills these requirements**
* [x] Cheatsheets are up-to-date (run `go generate ./...`)
* [x] Code has been formatted (see
[here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#code-formatting))
* [x] Tests have been added/updated (see
[here](https://github.com/jesseduffield/lazygit/blob/master/pkg/integration/README.md)
for the integration test guide)
* [ ] Text is internationalised (see
[here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#internationalisation))
* [ ] Docs have been updated if necessary
* [x] You've read through your own file changes for silly mistakes etc
Diffstat (limited to 'pkg/utils/formatting.go')
0 files changed, 0 insertions, 0 deletions