summaryrefslogtreecommitdiffstats
path: root/pkg/tasks
diff options
context:
space:
mode:
authorJesse Duffield <jessedduffield@gmail.com>2021-04-09 20:16:35 +1000
committerJesse Duffield <jessedduffield@gmail.com>2021-04-09 22:50:55 +1000
commit93fac1f3124f87009091230f61cc13b5e5473cb5 (patch)
treee3ce82feb812357a3b325883ae00388f7f73aa57 /pkg/tasks
parentd5504fa5d0d4e0312e1b27b8dbe3c6c664395a31 (diff)
reduce flicker without worrying about carriage returns
Diffstat (limited to 'pkg/tasks')
-rw-r--r--pkg/tasks/tasks.go14
1 files changed, 9 insertions, 5 deletions
diff --git a/pkg/tasks/tasks.go b/pkg/tasks/tasks.go
index 5854b4f46..8287b3927 100644
--- a/pkg/tasks/tasks.go
+++ b/pkg/tasks/tasks.go
@@ -33,12 +33,13 @@ type ViewBufferManager struct {
readLines chan int
// beforeStart is the function that is called before starting a new task
- beforeStart func()
- refreshView func()
+ beforeStart func()
+ refreshView func()
+ flushStaleCells func()
}
-func NewViewBufferManager(log *logrus.Entry, writer io.Writer, beforeStart func(), refreshView func()) *ViewBufferManager {
- return &ViewBufferManager{Log: log, writer: writer, beforeStart: beforeStart, refreshView: refreshView, readLines: make(chan int, 1024)}
+func NewViewBufferManager(log *logrus.Entry, writer io.Writer, beforeStart func(), refreshView func(), flushStaleCells func()) *ViewBufferManager {
+ return &ViewBufferManager{Log: log, writer: writer, beforeStart: beforeStart, refreshView: refreshView, flushStaleCells: flushStaleCells, readLines: make(chan int, 1024)}
}
func (m *ViewBufferManager) ReadLines(n int) {
@@ -75,7 +76,7 @@ func (m *ViewBufferManager) NewCmdTask(r io.Reader, cmd *exec.Cmd, prefix string
loaded := false
go utils.Safe(func() {
- ticker := time.NewTicker(time.Millisecond * 100)
+ ticker := time.NewTicker(time.Millisecond * 200)
defer ticker.Stop()
select {
case <-ticker.C:
@@ -114,6 +115,9 @@ func (m *ViewBufferManager) NewCmdTask(r io.Reader, cmd *exec.Cmd, prefix string
default:
}
if !ok {
+ // if we're here then there's nothing left to scan from the source
+ // so we're at the EOF and can flush the stale content
+ m.flushStaleCells()
m.refreshView()
break outer
}