summaryrefslogtreecommitdiffstats
path: root/pkg/integration
diff options
context:
space:
mode:
authorStefan Haller <stefan@haller-berlin.de>2024-03-08 21:19:10 +0100
committerStefan Haller <stefan@haller-berlin.de>2024-03-09 07:43:48 +0100
commit40232440b7249b8e214265cbb13a9c84bf5e2d05 (patch)
tree252aab39302a832ba5d4dc77ebe31db038db0b28 /pkg/integration
parent44f553b6093c69d09718f617e0a7659c64f51015 (diff)
Support setting a range of commits to "edit" outside of a rebase
It starts a rebase on the bottom-most commit of the range, and sets all the selected commits to "edit" (skipping merge commits, because they can't be edited).
Diffstat (limited to 'pkg/integration')
-rw-r--r--pkg/integration/tests/interactive_rebase/edit_range_select_outside_rebase.go51
-rw-r--r--pkg/integration/tests/interactive_rebase/mid_rebase_range_select.go21
-rw-r--r--pkg/integration/tests/test_list.go1
3 files changed, 52 insertions, 21 deletions
diff --git a/pkg/integration/tests/interactive_rebase/edit_range_select_outside_rebase.go b/pkg/integration/tests/interactive_rebase/edit_range_select_outside_rebase.go
new file mode 100644
index 000000000..4ff2a8c83
--- /dev/null
+++ b/pkg/integration/tests/interactive_rebase/edit_range_select_outside_rebase.go
@@ -0,0 +1,51 @@
+package interactive_rebase
+
+import (
+ "github.com/jesseduffield/lazygit/pkg/config"
+ . "github.com/jesseduffield/lazygit/pkg/integration/components"
+ "github.com/jesseduffield/lazygit/pkg/integration/tests/shared"
+)
+
+var EditRangeSelectOutsideRebase = NewIntegrationTest(NewIntegrationTestArgs{
+ Description: "Select a range of commits to edit outside of a rebase",
+ ExtraCmdArgs: []string{},
+ Skip: false,
+ GitVersion: AtLeast("2.22.0"), // first version that supports the --rebase-merges option
+ SetupConfig: func(config *config.AppConfig) {},
+ SetupRepo: func(shell *Shell) {
+ shared.CreateMergeCommit(shell)
+ },
+ Run: func(t *TestDriver, keys config.KeybindingConfig) {
+ t.Views().Commits().
+ Focus().
+ TopLines(
+ Contains("Merge branch 'second-change-branch' into first-change-branch").IsSelected(),
+ ).
+ Press(keys.Universal.RangeSelectDown).
+ Press(keys.Universal.RangeSelectDown).
+ Press(keys.Universal.RangeSelectDown).
+ Press(keys.Universal.RangeSelectDown).
+ Press(keys.Universal.RangeSelectDown).
+ Lines(
+ Contains("CI ⏣─╮ Merge branch 'second-change-branch' into first-change-branch").IsSelected(),
+ Contains("CI │ ◯ * second-change-branch unrelated change").IsSelected(),
+ Contains("CI │ ◯ second change").IsSelected(),
+ Contains("CI ◯ │ first change").IsSelected(),
+ Contains("CI ◯─╯ * original").IsSelected(),
+ Contains("CI ◯ three").IsSelected(),
+ Contains("CI ◯ two"),
+ Contains("CI ◯ one"),
+ ).
+ Press(keys.Universal.Edit).
+ Lines(
+ Contains("merge CI Merge branch 'second-change-branch' into first-change-branch").IsSelected(),
+ Contains("edit CI first change").IsSelected(),
+ Contains("edit CI * second-change-branch unrelated change").IsSelected(),
+ Contains("edit CI second change").IsSelected(),
+ Contains("edit CI * original").IsSelected(),
+ Contains(" CI ◯ <-- YOU ARE HERE --- three").IsSelected(),
+ Contains(" CI ◯ two"),
+ Contains(" CI ◯ one"),
+ )
+ },
+})
diff --git a/pkg/integration/tests/interactive_rebase/mid_rebase_range_select.go b/pkg/integration/tests/interactive_rebase/mid_rebase_range_select.go
index 6dcb12ea6..c94b63295 100644
--- a/pkg/integration/tests/interactive_rebase/mid_rebase_range_select.go
+++ b/pkg/integration/tests/interactive_rebase/mid_rebase_range_select.go
@@ -20,27 +20,6 @@ var MidRebaseRangeSelect = NewIntegrationTest(NewIntegrationTestArgs{
TopLines(
Contains("commit 10").IsSelected(),
).
- NavigateToLine(Contains("commit 07")).
- Press(keys.Universal.RangeSelectDown).
- TopLines(
- Contains("commit 10"),
- Contains("commit 09"),
- Contains("commit 08"),
- Contains("commit 07").IsSelected(),
- Contains("commit 06").IsSelected(),
- Contains("commit 05"),
- Contains("commit 04"),
- ).
- // Verify we can't perform an edit on multiple commits (it's not supported
- // yet)
- Press(keys.Universal.Edit).
- Tap(func() {
- // This ought to be a toast but I'm too lazy to implement that right now.
- t.ExpectPopup().Alert().
- Title(Equals("Error")).
- Content(Contains("Action does not support range selection, please select a single item")).
- Confirm()
- }).
NavigateToLine(Contains("commit 05")).
// Start a rebase
Press(keys.Universal.Edit).
diff --git a/pkg/integration/tests/test_list.go b/pkg/integration/tests/test_list.go
index 531fce5d9..d0525fa59 100644
--- a/pkg/integration/tests/test_list.go
+++ b/pkg/integration/tests/test_list.go
@@ -167,6 +167,7 @@ var tests = []*components.IntegrationTest{
interactive_rebase.DropWithCustomCommentChar,
interactive_rebase.EditFirstCommit,
interactive_rebase.EditNonTodoCommitDuringRebase,
+ interactive_rebase.EditRangeSelectOutsideRebase,
interactive_rebase.EditTheConflCommit,
interactive_rebase.FixupFirstCommit,
interactive_rebase.FixupSecondCommit,