diff options
author | Stefan Haller <stefan@haller-berlin.de> | 2023-03-28 18:00:40 +0200 |
---|---|---|
committer | Stefan Haller <stefan@haller-berlin.de> | 2023-04-13 13:14:00 +0200 |
commit | e4e16fa38ea5d89fb139c5153338e32d1eeafede (patch) | |
tree | 800d63b724b82a5c8dc5d9de6021a5e46306ebfc /pkg/commands | |
parent | b7e029adc7c5cf27ae2c5db768b971a959fa2449 (diff) |
Change OpenCommand to Open and OpenLinkCommand to OpenLink
We do this for consistency with the edit settings. The old names are kept as a
fallback for now.
Diffstat (limited to 'pkg/commands')
-rw-r--r-- | pkg/commands/oscommands/os.go | 16 | ||||
-rw-r--r-- | pkg/commands/oscommands/os_default_test.go | 4 |
2 files changed, 14 insertions, 6 deletions
diff --git a/pkg/commands/oscommands/os.go b/pkg/commands/oscommands/os.go index f66f25b72..c8f38843b 100644 --- a/pkg/commands/oscommands/os.go +++ b/pkg/commands/oscommands/os.go @@ -78,9 +78,13 @@ func FileType(path string) string { } func (c *OSCommand) OpenFile(filename string) error { - commandTemplate := c.UserConfig.OS.OpenCommand + commandTemplate := c.UserConfig.OS.Open if commandTemplate == "" { - commandTemplate = config.GetPlatformDefaultConfig().OpenCommand + // Legacy support + commandTemplate = c.UserConfig.OS.OpenCommand + } + if commandTemplate == "" { + commandTemplate = config.GetPlatformDefaultConfig().Open } templateValues := map[string]string{ "filename": c.Quote(filename), @@ -90,9 +94,13 @@ func (c *OSCommand) OpenFile(filename string) error { } func (c *OSCommand) OpenLink(link string) error { - commandTemplate := c.UserConfig.OS.OpenLinkCommand + commandTemplate := c.UserConfig.OS.OpenLink + if commandTemplate == "" { + // Legacy support + commandTemplate = c.UserConfig.OS.OpenLinkCommand + } if commandTemplate == "" { - commandTemplate = config.GetPlatformDefaultConfig().OpenLinkCommand + commandTemplate = config.GetPlatformDefaultConfig().OpenLink } templateValues := map[string]string{ "link": c.Quote(link), diff --git a/pkg/commands/oscommands/os_default_test.go b/pkg/commands/oscommands/os_default_test.go index 39a1226d2..1f534f6d3 100644 --- a/pkg/commands/oscommands/os_default_test.go +++ b/pkg/commands/oscommands/os_default_test.go @@ -75,7 +75,7 @@ func TestOSCommandOpenFileDarwin(t *testing.T) { for _, s := range scenarios { oSCmd := NewDummyOSCommandWithRunner(s.runner) oSCmd.Platform.OS = "darwin" - oSCmd.UserConfig.OS.OpenCommand = "open {{filename}}" + oSCmd.UserConfig.OS.Open = "open {{filename}}" s.test(oSCmd.OpenFile(s.filename)) } @@ -135,7 +135,7 @@ func TestOSCommandOpenFileLinux(t *testing.T) { for _, s := range scenarios { oSCmd := NewDummyOSCommandWithRunner(s.runner) oSCmd.Platform.OS = "linux" - oSCmd.UserConfig.OS.OpenCommand = `xdg-open {{filename}} > /dev/null` + oSCmd.UserConfig.OS.Open = `xdg-open {{filename}} > /dev/null` s.test(oSCmd.OpenFile(s.filename)) } |