diff options
| author | Jesse Duffield <jessedduffield@gmail.com> | 2020-02-25 22:08:03 +1100 |
|---|---|---|
| committer | Jesse Duffield <jessedduffield@gmail.com> | 2020-02-25 22:09:43 +1100 |
| commit | 8eb0b0f4caee4044acd278eb18c901bc7312dfe3 (patch) | |
| tree | 074e7b34b812b7395972eb4b256ff11a5e30ba0b | |
| parent | e6a8dc0bcfc8b8ceb21ea685509e1382ac591190 (diff) | |
do not close over variables in a functionv0.15.3
| -rw-r--r-- | pkg/gui/rebase_options_panel.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/pkg/gui/rebase_options_panel.go b/pkg/gui/rebase_options_panel.go index f1e87b235..2187cef58 100644 --- a/pkg/gui/rebase_options_panel.go +++ b/pkg/gui/rebase_options_panel.go @@ -16,10 +16,12 @@ func (gui *Gui) handleCreateRebaseOptionsMenu(g *gocui.Gui, v *gocui.View) error menuItems := make([]*menuItem, len(options)) for i, option := range options { + // note to self. Never, EVER, close over loop variables in a function + innerOption := option menuItems[i] = &menuItem{ - displayString: option, + displayString: innerOption, onPress: func() error { - return gui.genericMergeCommand(option) + return gui.genericMergeCommand(innerOption) }, } } |