diff options
author | Matthias Beyer <mail@beyermatthias.de> | 2018-10-04 16:11:11 +0200 |
---|---|---|
committer | Matthias Beyer <mail@beyermatthias.de> | 2018-10-06 12:22:15 +0200 |
commit | 1161562372f58ee557fa9d5e3cb67a79e985716b (patch) | |
tree | 57f404b73a2f5cfcd923d34ce6810d5054e47177 /lib/core/libimagrt/src/logger.rs | |
parent | 5d901ae41163c02a39e23ee2baf8577f79197411 (diff) |
Remove handlebars exception in log implementation
The issue was that the handlebars implementation logs as well and if we
use handlebars in the logger implementation that causes recursion which
crashes the program.
With handlebars 1.0.5, there is a feature[0] to disable logging in
handlebars (compiletime) which we use with this patch. The
exception-checking in the log implementation can be removed therefore.
[0]: https://github.com/sunng87/handlebars-rust/pull/236#issuecomment-427014611
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Diffstat (limited to 'lib/core/libimagrt/src/logger.rs')
-rw-r--r-- | lib/core/libimagrt/src/logger.rs | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/lib/core/libimagrt/src/logger.rs b/lib/core/libimagrt/src/logger.rs index 8d5d2e4d..f7d09697 100644 --- a/lib/core/libimagrt/src/logger.rs +++ b/lib/core/libimagrt/src/logger.rs @@ -131,18 +131,6 @@ impl Log for ImagLogger { } fn log(&self, record: &Record) { - if record.module_path().map(|m| m.starts_with("handlebars")).unwrap_or(false) { - // This is a ugly, yet necessary hack. When logging, we use handlebars for templating. - // But as the handlebars library itselfs logs via a normal logging macro ("debug!()"), - // we have a recursion in our chain. - // - // To prevent this recursion, we return here. - // - // (As of handlebars 0.29.0 - please check whether you can update handlebars if you see - // this. Hopefully the next version has a compiletime flag to disable logging) - return; - } - let mut data = BTreeMap::new(); { |