diff options
author | Joe Mooring <joe.mooring@veriphor.com> | 2024-04-25 08:18:40 -0700 |
---|---|---|
committer | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2024-05-14 14:45:04 +0200 |
commit | 74ab839ccb397ea9df1c96d71c5347f49f2b231a (patch) | |
tree | 35a09fe7f5ccbec407f142360cd8739090215bf4 /tpl | |
parent | 92290aa89263dcaa73149a725be9451ab69b8926 (diff) |
tpl/tplimpl: Plainify title and description in twitter_cards.html
Closes #12433
Improves #10900
Diffstat (limited to 'tpl')
-rw-r--r-- | tpl/tplimpl/embedded/templates/twitter_cards.html | 24 | ||||
-rw-r--r-- | tpl/tplimpl/tplimpl_integration_test.go | 77 |
2 files changed, 92 insertions, 9 deletions
diff --git a/tpl/tplimpl/embedded/templates/twitter_cards.html b/tpl/tplimpl/embedded/templates/twitter_cards.html index 14c92274b..6f156c7a7 100644 --- a/tpl/tplimpl/embedded/templates/twitter_cards.html +++ b/tpl/tplimpl/embedded/templates/twitter_cards.html @@ -1,12 +1,18 @@ -{{- $images := partial "_funcs/get-page-images" . -}} -{{- with index $images 0 -}} -<meta name="twitter:card" content="summary_large_image"> -<meta name="twitter:image" content="{{ .Permalink }}"> -{{- else -}} -<meta name="twitter:card" content="summary"> -{{- end -}} -<meta name="twitter:title" content="{{ .Title }}"> -<meta name="twitter:description" content="{{ with .Description }}{{ . }}{{ else }}{{if .IsPage}}{{ .Summary }}{{ else }}{{ with .Site.Params.description }}{{ . }}{{ end }}{{ end }}{{ end -}}"> +{{- $images := partial "_funcs/get-page-images" . }} +{{- with index $images 0 }} + <meta name="twitter:card" content="summary_large_image"> + <meta name="twitter:image" content="{{ .Permalink }}"> +{{- else }} + <meta name="twitter:card" content="summary"> +{{- end }} + +{{- with or .Title site.Title site.Params.title | plainify }} + <meta name="twitter:title" content="{{ . }}"> +{{- end }} + +{{- with or .Description .Summary site.Params.description | plainify | htmlUnescape | chomp }} + <meta name="twitter:description" content="{{ . }}"> +{{- end }} {{- $twitterSite := "" }} {{- with site.Params.social }} diff --git a/tpl/tplimpl/tplimpl_integration_test.go b/tpl/tplimpl/tplimpl_integration_test.go index b30965be9..41257912d 100644 --- a/tpl/tplimpl/tplimpl_integration_test.go +++ b/tpl/tplimpl/tplimpl_integration_test.go @@ -493,3 +493,80 @@ title: p5 `<meta itemprop="description" content="m n and **o** can't.">`, ) } + +// Issue 12433 +func TestTwitterCards(t *testing.T) { + t.Parallel() + + files := ` +-- hugo.toml -- +capitalizeListTitles = false +disableKinds = ['rss','sitemap','taxonomy','term'] +[markup.goldmark.renderer] +unsafe = true +[params] +description = "m <em>n</em> and **o** can't." +[params.social] +twitter = 'foo' +-- layouts/_default/list.html -- +{{ template "_internal/twitter_cards.html" . }} +-- layouts/_default/single.html -- +{{ template "_internal/twitter_cards.html" . }} +-- content/s1/p1.md -- +--- +title: p1 +images: [a.jpg,b.jpg] +--- +a <em>b</em> and **c** can't. +-- content/s1/p2.md -- +--- +title: p2 +--- +d <em>e</em> and **f** can't. +<!--more--> +-- content/s1/p3.md -- +--- +title: p3 +summary: g <em>h</em> and **i** can't. +--- +-- content/s1/p4.md -- +--- +title: p4 +description: j <em>k</em> and **l** can't. +--- +-- content/s1/p5.md -- +--- +title: p5 +--- +` + + b := hugolib.Test(t, files) + + b.AssertFileContent("public/s1/p1/index.html", ` + <meta name="twitter:card" content="summary_large_image"> + <meta name="twitter:image" content="/a.jpg"> + <meta name="twitter:title" content="p1"> + <meta name="twitter:description" content="a b and c can’t."> + <meta name="twitter:site" content="@foo"> + `, + ) + + b.AssertFileContent("public/s1/p2/index.html", + `<meta name="twitter:card" content="summary">`, + `<meta name="twitter:description" content="d e and f can’t.">`, + ) + + b.AssertFileContent("public/s1/p3/index.html", + `<meta name="twitter:description" content="g h and i can’t.">`, + ) + + // The markdown is intentionally not rendered to HTML. + b.AssertFileContent("public/s1/p4/index.html", + `<meta name="twitter:description" content="j k and **l** can't.">`, + ) + + // The markdown is intentionally not rendered to HTML. + b.AssertFileContent("public/s1/p5/index.html", + `<meta name="twitter:description" content="m n and **o** can't.">`, + ) +} |