diff options
| author | Nicolas Hennion <nicolashennion@gmail.com> | 2024-01-03 07:23:09 +0000 |
|---|---|---|
| committer | Nicolas Hennion <nicolashennion@gmail.com> | 2024-01-03 07:23:09 +0000 |
| commit | 5832ad3d994a97a203a21f787e18e5cb4e54f44c (patch) | |
| tree | 0dfcbc8c025b433f9a9f3f6135577b2d91b633c9 | |
| parent | 03cf200d062ed06666043887efb03321013526e4 (diff) | |
Docker memory usage uses the same algorithm than docker stats #26372637-docker-memory-usage-is-incorrect
| -rw-r--r-- | NEWS.rst | 1 | ||||
| -rw-r--r-- | glances/outputs/static/js/components/plugin-containers.vue | 4 | ||||
| -rw-r--r-- | glances/plugins/containers/engines/docker.py | 6 |
3 files changed, 7 insertions, 4 deletions
@@ -23,6 +23,7 @@ Under development: https://github.com/nicolargo/glances/issues?q=is%3Aopen+is%3A alias=sda1:InternalDisk,sdb1:ExternalDisk * Alert data model change from a list of list to a list of dict #2633 + * Docker memory usage uses the same algorithm than docker stats #2637 =============== Version 3.4.0.3 diff --git a/glances/outputs/static/js/components/plugin-containers.vue b/glances/outputs/static/js/components/plugin-containers.vue index cadfc3bd..b7fb02a5 100644 --- a/glances/outputs/static/js/components/plugin-containers.vue +++ b/glances/outputs/static/js/components/plugin-containers.vue @@ -54,7 +54,7 @@ {{ $filters.number(container.cpu_percent, 1) }} </div> <div class="table-cell"> - {{ $filters.bytes(container.memory_usage_no_cache) }} + {{ $filters.bytes(container.memory_usage) }} </div> <div class="table-cell"> {{ $filters.bytes(container.limit) }} @@ -123,7 +123,7 @@ export default { 'status': containerData.status, 'uptime': containerData.uptime, 'cpu_percent': containerData.cpu.total, - 'memory_usage_no_cache': memory_usage_no_cache, + 'memory_usage': memory_usage_no_cache, 'limit': containerData.memory.limit != undefined ? containerData.memory.limit : '?', 'io_rx': containerData.io_rx != undefined ? containerData.io_rx : '?', 'io_wx': containerData.io_wx != undefined ? containerData.io_wx : '?', diff --git a/glances/plugins/containers/engines/docker.py b/glances/plugins/containers/engines/docker.py index 1c973713..bf27969c 100644 --- a/glances/plugins/containers/engines/docker.py +++ b/glances/plugins/containers/engines/docker.py @@ -120,7 +120,9 @@ class DockerStatsFetcher: def _get_memory_stats(self): """Return the container MEMORY. - Output: a dict {'usage': ..., 'limit': ..., 'max_usage': ...} + Output: a dict {'usage': ..., 'limit': ..., 'inactive_file': ...} + + Note:the displayed memory usage is 'usage - inactive_file' """ memory_stats = self._streamer.stats.get('memory_stats') @@ -131,7 +133,7 @@ class DockerStatsFetcher: stats = {field: memory_stats[field] for field in self.MANDATORY_MEMORY_FIELDS} - # Optional field + # Optional field stats:inactive_file stats['inactive_file'] = 0 if 'stats' in memory_stats: stats['inactive_file'] = memory_stats['stats'].get('inactive_file', 0) |