diff options
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | gitlint/rules.py | 2 | ||||
| -rw-r--r-- | gitlint/tests/expected/test_cli/test_debug_1 | 2 | ||||
| -rw-r--r-- | gitlint/tests/expected/test_cli/test_input_stream_debug_2 | 2 | ||||
| -rw-r--r-- | gitlint/tests/expected/test_cli/test_lint_staged_msg_filename_2 | 2 | ||||
| -rw-r--r-- | gitlint/tests/expected/test_cli/test_lint_staged_stdin_2 | 2 | ||||
| -rw-r--r-- | gitlint/tests/expected/test_cli/test_named_rules_2 | 2 | ||||
| -rw-r--r-- | qa/expected/test_commits/test_lint_staged_msg_filename_1 | 2 | ||||
| -rw-r--r-- | qa/expected/test_commits/test_lint_staged_stdin_1 | 2 | ||||
| -rw-r--r-- | qa/expected/test_config/test_config_from_file_debug_1 | 2 |
10 files changed, 10 insertions, 10 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 402dc9f..8e8bb83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ the lines in a commit message body. ([#126](https://github.com/jorisroovers/gitl - Options can now actually be set to `None` (from code) to make them optional. - Ignore rules no longer have "None" as default regex, but an empty regex - effectively disabling them by default (as intended). - New `RegexOption` rule option type for use in user-defined rules. By using the `RegexOption`, regular expressions are pre-validated at gitlint startup and compiled only once which is much more efficient compared when linting multiple commits. - +- Minor performance improvement: Removed some unneccessary regex matching ## v0.13.1 (2020-02-26) diff --git a/gitlint/rules.py b/gitlint/rules.py index 9cdb9a5..5d04580 100644 --- a/gitlint/rules.py +++ b/gitlint/rules.py @@ -231,7 +231,7 @@ class TitleRegexMatches(LineRule): name = "title-match-regex" id = "T7" target = CommitMessageTitle - options_spec = [RegexOption('regex', ".*", "Regex the title should match")] + options_spec = [RegexOption('regex', None, "Regex the title should match")] def validate(self, title, _commit): # If no regex is specified, immediately return diff --git a/gitlint/tests/expected/test_cli/test_debug_1 b/gitlint/tests/expected/test_cli/test_debug_1 index bb239c6..b6ef0e7 100644 --- a/gitlint/tests/expected/test_cli/test_debug_1 +++ b/gitlint/tests/expected/test_cli/test_debug_1 @@ -38,7 +38,7 @@ target: {target} T5: title-must-not-contain-word words=WIP,bögus T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=30 B5: body-min-length diff --git a/gitlint/tests/expected/test_cli/test_input_stream_debug_2 b/gitlint/tests/expected/test_cli/test_input_stream_debug_2 index 015e62e..86f2a1b 100644 --- a/gitlint/tests/expected/test_cli/test_input_stream_debug_2 +++ b/gitlint/tests/expected/test_cli/test_input_stream_debug_2 @@ -38,7 +38,7 @@ target: {target} T5: title-must-not-contain-word words=WIP T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/gitlint/tests/expected/test_cli/test_lint_staged_msg_filename_2 b/gitlint/tests/expected/test_cli/test_lint_staged_msg_filename_2 index f4d9842..9e18acb 100644 --- a/gitlint/tests/expected/test_cli/test_lint_staged_msg_filename_2 +++ b/gitlint/tests/expected/test_cli/test_lint_staged_msg_filename_2 @@ -38,7 +38,7 @@ target: {target} T5: title-must-not-contain-word words=WIP T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/gitlint/tests/expected/test_cli/test_lint_staged_stdin_2 b/gitlint/tests/expected/test_cli/test_lint_staged_stdin_2 index c263b78..f874696 100644 --- a/gitlint/tests/expected/test_cli/test_lint_staged_stdin_2 +++ b/gitlint/tests/expected/test_cli/test_lint_staged_stdin_2 @@ -38,7 +38,7 @@ target: {target} T5: title-must-not-contain-word words=WIP T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/gitlint/tests/expected/test_cli/test_named_rules_2 b/gitlint/tests/expected/test_cli/test_named_rules_2 index 776b893..ec1f0a7 100644 --- a/gitlint/tests/expected/test_cli/test_named_rules_2 +++ b/gitlint/tests/expected/test_cli/test_named_rules_2 @@ -38,7 +38,7 @@ target: {target} T5: title-must-not-contain-word words=WIP,bögus T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/qa/expected/test_commits/test_lint_staged_msg_filename_1 b/qa/expected/test_commits/test_lint_staged_msg_filename_1 index 2471cf5..5928cc1 100644 --- a/qa/expected/test_commits/test_lint_staged_msg_filename_1 +++ b/qa/expected/test_commits/test_lint_staged_msg_filename_1 @@ -39,7 +39,7 @@ target: {target} T5: title-must-not-contain-word words=WIP T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/qa/expected/test_commits/test_lint_staged_stdin_1 b/qa/expected/test_commits/test_lint_staged_stdin_1 index 1f06faa..672a5a7 100644 --- a/qa/expected/test_commits/test_lint_staged_stdin_1 +++ b/qa/expected/test_commits/test_lint_staged_stdin_1 @@ -39,7 +39,7 @@ target: {target} T5: title-must-not-contain-word words=WIP T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=80 B5: body-min-length diff --git a/qa/expected/test_config/test_config_from_file_debug_1 b/qa/expected/test_config/test_config_from_file_debug_1 index e04df37..6659a28 100644 --- a/qa/expected/test_config/test_config_from_file_debug_1 +++ b/qa/expected/test_config/test_config_from_file_debug_1 @@ -39,7 +39,7 @@ target: {target} T5: title-must-not-contain-word words=WIP,thåt T7: title-match-regex - regex=.* + regex=None B1: body-max-line-length line-length=30 B5: body-min-length |