refactor: if-else to switch

3 files changed, 17 insertions, 13 deletions

diff --git a/cmd/gdu/app/app.go b/cmd/gdu/app/app.go
index 802921b..7f9612c 100644
--- a/cmd/gdu/app/app.go
+++ b/cmd/gdu/app/app.go
@@ -210,7 +210,8 @@ func (a *App) setMaxProcs() {
 func (a *App) createUI() (UI, error) {
 	var ui UI
 
-	if a.Flags.OutputFile != "" {
+	switch {
+	case a.Flags.OutputFile != "":
 		var output io.Writer
 		var err error
 		if a.Flags.OutputFile == "-" {
@@ -229,7 +230,7 @@ func (a *App) createUI() (UI, error) {
 			a.Flags.ConstGC,
 			a.Flags.UseSIPrefix,
 		)
-	} else if a.Flags.NonInteractive || !a.Istty {
+	case a.Flags.NonInteractive || !a.Istty:
 		ui = stdout.CreateStdoutUI(
 			a.Writer,
 			!a.Flags.NoColor && a.Istty,
@@ -241,7 +242,7 @@ func (a *App) createUI() (UI, error) {
 			a.Flags.UseSIPrefix,
 			a.Flags.NoPrefix,
 		)
-	} else {
+	default:
 		var opts []tui.Option
 
 		if a.Flags.Style.SelectedRow.TextColor != "" {
@@ -348,11 +349,12 @@ func (a *App) runAction(ui UI, path string) error {
 		}()
 	}
 
-	if a.Flags.ShowDisks {
+	switch {
+	case a.Flags.ShowDisks:
 		if err := ui.ListDevices(a.Getter); err != nil {
 			return fmt.Errorf("loading mount points: %w", err)
 		}
-	} else if a.Flags.InputFile != "" {
+	case a.Flags.InputFile != "":
 		var input io.Reader
 		var err error
 		if a.Flags.InputFile == "-" {
@@ -367,12 +369,12 @@ func (a *App) runAction(ui UI, path string) error {
 		if err := ui.ReadAnalysis(input); err != nil {
 			return fmt.Errorf("reading analysis: %w", err)
 		}
-	} else if a.Flags.ReadFromStorage {
+	case a.Flags.ReadFromStorage:
 		ui.SetAnalyzer(analyze.CreateStoredAnalyzer(a.Flags.StoragePath))
 		if err := ui.ReadFromStorage(a.Flags.StoragePath, path); err != nil {
 			return fmt.Errorf("reading from storage (%s): %w", a.Flags.StoragePath, err)
 		}
-	} else {
+	default:
 		if build.RootPathPrefix != "" {
 			path = build.RootPathPrefix + path
 		}
diff --git a/tui/format.go b/tui/format.go
index 001c004..03d4460 100644
--- a/tui/format.go
+++ b/tui/format.go
@@ -24,11 +24,12 @@ const (
 func (ui *UI) formatFileRow(item fs.Item, maxUsage int64, maxSize int64, marked, ignored bool) string {
 	var part int
 
-	if ignored {
+	switch {
+	case ignored:
 		part = 0
-	} else if ui.ShowApparentSize {
+	case ui.ShowApparentSize:
 		part = int(float64(item.GetSize()) / float64(maxSize) * 100.0)
-	} else {
+	default:
 		part = int(float64(item.GetUsage()) / float64(maxUsage) * 100.0)
 	}
 
diff --git a/tui/show.go b/tui/show.go
index e194f48..b8709fd 100644
--- a/tui/show.go
+++ b/tui/show.go
@@ -131,12 +131,13 @@ func (ui *UI) showDir() {
 		cell := tview.NewTableCell(ui.formatFileRow(item, maxUsage, maxSize, marked, ignored))
 		cell.SetReference(ui.currentDir.GetFiles()[i])
 
-		if ignored {
+		switch {
+		case ignored:
 			cell.SetStyle(tcell.Style{}.Foreground(tview.Styles.SecondaryTextColor))
-		} else if marked {
+		case marked:
 			cell.SetStyle(tcell.Style{}.Foreground(tview.Styles.PrimaryTextColor))
 			cell.SetBackgroundColor(tview.Styles.ContrastBackgroundColor)
-		} else {
+		default:
 			cell.SetStyle(tcell.Style{}.Foreground(tcell.ColorDefault))
 		}