diff options
author | Matthias Beyer <mail@beyermatthias.de> | 2021-03-04 13:34:13 +0100 |
---|---|---|
committer | Matthias Beyer <mail@beyermatthias.de> | 2021-03-04 13:34:54 +0100 |
commit | 5b46db841f74663c896c37e5f40a4ad08699ba2b (patch) | |
tree | 7eb3b4875b90d33c834efcc206ddb5952d93f915 /src/package | |
parent | e83155b64527de035b55d57c12c96463f0443b84 (diff) |
Do not pass progress bars by value, but by reference
Because passing by value is simply not necessary here.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Diffstat (limited to 'src/package')
-rw-r--r-- | src/package/dag.rs | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/package/dag.rs b/src/package/dag.rs index 7ad475b..e7b8dc3 100644 --- a/src/package/dag.rs +++ b/src/package/dag.rs @@ -40,7 +40,7 @@ impl Dag { pub fn for_root_package( p: Package, repo: &Repository, - progress: ProgressBar, + progress: &ProgressBar, ) -> Result<Self> { fn add_sub_packages<'a>( repo: &'a Repository, @@ -100,7 +100,7 @@ impl Dag { trace!("Making package Tree for {:?}", p); let root_idx = dag.add_node(&p); mappings.insert(&p, root_idx); - add_sub_packages(repo, &mut mappings, &mut dag, &p, &progress)?; + add_sub_packages(repo, &mut mappings, &mut dag, &p, progress)?; add_edges(&mappings, &mut dag)?; trace!("Finished makeing package Tree"); @@ -179,7 +179,7 @@ mod tests { let repo = Repository::from(btree); let progress = ProgressBar::hidden(); - let r = Dag::for_root_package(p1, &repo, progress); + let r = Dag::for_root_package(p1, &repo, &progress); assert!(r.is_ok()); } @@ -211,7 +211,7 @@ mod tests { let repo = Repository::from(btree); let progress = ProgressBar::hidden(); - let dag = Dag::for_root_package(p1, &repo, progress); + let dag = Dag::for_root_package(p1, &repo, &progress); assert!(dag.is_ok()); let dag = dag.unwrap(); let ps = dag.all_packages(); @@ -300,7 +300,7 @@ mod tests { let repo = Repository::from(btree); let progress = ProgressBar::hidden(); - let r = Dag::for_root_package(p1, &repo, progress); + let r = Dag::for_root_package(p1, &repo, &progress); assert!(r.is_ok()); let r = r.unwrap(); let ps = r.all_packages(); @@ -443,7 +443,7 @@ mod tests { let repo = Repository::from(btree); let progress = ProgressBar::hidden(); - let r = Dag::for_root_package(p1, &repo, progress); + let r = Dag::for_root_package(p1, &repo, &progress); assert!(r.is_ok()); let r = r.unwrap(); let ps = r.all_packages(); @@ -548,7 +548,7 @@ mod tests { let repo = Repository::from(btree); let progress = ProgressBar::hidden(); - let r = Dag::for_root_package(p1, &repo, progress); + let r = Dag::for_root_package(p1, &repo, &progress); assert!(r.is_ok()); let r = r.unwrap(); let ps = r.all_packages(); |