summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2016-04-28 16:11:30 +0200
committerTobias Klauser <tklauser@distanz.ch>2016-04-28 16:11:30 +0200
commitf177718f24c050c458f9ec8f944a8f2cea92b372 (patch)
treebb7a37ddff73ab12bb082e583054c292d5ea0581
parentcc22e4e35d95f309ad55b35bedca06ecabfeb014 (diff)
format: Add missing braces around 'if' clause
When compiling bmon with gcc 6.1 it complains with the following warning: out_format.c: In function ‘get_token’: out_format.c:134:10: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] } else if (!strncasecmp(token+5, "txrate:", 7)) ^~ out_format.c:136:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ return buf; ^~~~~~ Indeed, the 'return buf' should only be executed if it was snprintf()'ed to. Otherwise "unknown" should be returned. Fix this by adding braces. Also use the 'type' variable in strncasecmp() as in the other checks. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
-rw-r--r--src/out_format.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/out_format.c b/src/out_format.c
index d9d5e36..aea38c5 100644
--- a/src/out_format.c
+++ b/src/out_format.c
@@ -131,9 +131,10 @@ static char *get_token(struct element_group *g, struct element *e,
} else if (!strncasecmp(type, "rxrate:", 7)) {
snprintf(buf, len, "%.2f", a->a_rx_rate.r_rate);
return buf;
- } else if (!strncasecmp(token+5, "txrate:", 7))
+ } else if (!strncasecmp(type, "txrate:", 7)) {
snprintf(buf, len, "%.2f", a->a_tx_rate.r_rate);
return buf;
+ }
}
fprintf(stderr, "Unknown field \"%s\"\n", token);