summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeon Yang (Containers) <lnyng@meta.com>2024-04-26 07:11:10 -0700
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>2024-04-26 07:11:10 -0700
commit7df3e04aeef5ddc481a2a1de4ce594bba2fa6962 (patch)
treebb2c0785b1b8866f7e88e3f288327138655508a3
parent4acd7488eaea9147cd879b41ff9826dd8a45a52b (diff)
Rename system_view to summary_view
Summary: There is a misnomer of system_view since it can contain basic system info as well as cgroup, network, gpu metrics. It's more of a summary view. More importantly, core_view should actually be called system_view, which has a short cut of 's' that comes from "system". Reviewed By: brianc118 Differential Revision: D56504774 fbshipit-source-id: 13ac89113d26a2a7ea34c04c4fcd9c5c88c07497
-rw-r--r--below/view/src/controllers/sample_controllers.rs4
-rw-r--r--below/view/src/lib.rs8
-rw-r--r--below/view/src/summary_view.rs (renamed from below/view/src/system_view.rs)14
3 files changed, 13 insertions, 13 deletions
diff --git a/below/view/src/controllers/sample_controllers.rs b/below/view/src/controllers/sample_controllers.rs
index 69c128ff..427445b9 100644
--- a/below/view/src/controllers/sample_controllers.rs
+++ b/below/view/src/controllers/sample_controllers.rs
@@ -89,7 +89,7 @@ make_event_controller!(
_ => {}
};
crate::status_bar::refresh(c);
- crate::system_view::refresh(c);
+ crate::summary_view::refresh(c);
StatsView::<T>::refresh_myself(c);
}
);
@@ -115,7 +115,7 @@ make_event_controller!(
_ => {}
}
crate::status_bar::refresh(c);
- crate::system_view::refresh(c);
+ crate::summary_view::refresh(c);
StatsView::<T>::refresh_myself(c);
}
);
diff --git a/below/view/src/lib.rs b/below/view/src/lib.rs
index a1c481ea..59859d07 100644
--- a/below/view/src/lib.rs
+++ b/below/view/src/lib.rs
@@ -105,7 +105,7 @@ mod process_view;
mod render;
pub mod stats_view;
mod status_bar;
-mod system_view;
+mod summary_view;
mod tab_view;
pub struct View {
@@ -195,7 +195,7 @@ pub enum ViewMode {
// periodically (during live mode)
fn refresh(c: &mut Cursive) {
status_bar::refresh(c);
- system_view::refresh(c);
+ summary_view::refresh(c);
let current_state = c
.user_data::<ViewState>()
.expect("No data stored in Cursive object!")
@@ -403,7 +403,7 @@ impl View {
let init_warnings = get_last_log_to_display();
let status_bar = status_bar::new(&mut self.inner);
- let system_view = system_view::new(&mut self.inner);
+ let summary_view = summary_view::new(&mut self.inner);
let cgroup_view = cgroup_view::CgroupView::new(&mut self.inner, &viewrc);
let process_view = process_view::ProcessView::new(&mut self.inner);
let core_view = core_view::CoreView::new(&mut self.inner);
@@ -440,7 +440,7 @@ impl View {
.add_fullscreen_layer(ResizedView::with_full_screen(
LinearLayout::vertical()
.child(Panel::new(status_bar))
- .child(Panel::new(system_view))
+ .child(Panel::new(summary_view))
.child(
OnEventView::new(screens_view.with_name("main_view_screens"))
.with_name("dynamic_view"),
diff --git a/below/view/src/system_view.rs b/below/view/src/summary_view.rs
index 375cc50a..76977b40 100644
--- a/below/view/src/system_view.rs
+++ b/below/view/src/summary_view.rs
@@ -33,9 +33,9 @@ mod render_impl {
use crate::render::ViewItem;
/// Renders corresponding Fields From SystemModel.
- type SystemViewItem = ViewItem<model::SystemModelFieldId>;
+ type SummaryViewItem = ViewItem<model::SystemModelFieldId>;
- static SYS_CPU_ITEMS: Lazy<Vec<SystemViewItem>> = Lazy::new(|| {
+ static SYS_CPU_ITEMS: Lazy<Vec<SummaryViewItem>> = Lazy::new(|| {
use model::SingleCpuModelFieldId::SystemPct;
use model::SingleCpuModelFieldId::UsagePct;
use model::SingleCpuModelFieldId::UserPct;
@@ -47,7 +47,7 @@ mod render_impl {
]
});
- static SYS_MEM_ITEMS: Lazy<Vec<SystemViewItem>> = Lazy::new(|| {
+ static SYS_MEM_ITEMS: Lazy<Vec<SummaryViewItem>> = Lazy::new(|| {
use model::MemoryModelFieldId::Anon;
use model::MemoryModelFieldId::File;
use model::MemoryModelFieldId::Free;
@@ -61,7 +61,7 @@ mod render_impl {
]
});
- static SYS_VM_ITEMS: Lazy<Vec<SystemViewItem>> = Lazy::new(|| {
+ static SYS_VM_ITEMS: Lazy<Vec<SummaryViewItem>> = Lazy::new(|| {
use model::SystemModelFieldId::Vm;
use model::VmModelFieldId::PgpginPerSec;
use model::VmModelFieldId::PgpgoutPerSec;
@@ -189,8 +189,8 @@ fn fill_content(c: &mut Cursive, v: &mut LinearLayout) {
pub fn refresh(c: &mut Cursive) {
let mut v = c
- .find_name::<LinearLayout>("system_view")
- .expect("No system_view view found!");
+ .find_name::<LinearLayout>("summary_view")
+ .expect("No summary_view view found!");
fill_content(c, &mut v);
}
@@ -198,5 +198,5 @@ pub fn refresh(c: &mut Cursive) {
pub fn new(c: &mut Cursive) -> impl View {
let mut view = LinearLayout::vertical();
fill_content(c, &mut view);
- view.with_name("system_view")
+ view.with_name("summary_view")
}