diff options
author | Michael Weiser <michael.weiser@gmx.de> | 2019-02-14 21:59:53 +0000 |
---|---|---|
committer | Michael Weiser <michael.weiser@gmx.de> | 2019-02-18 17:58:58 +0000 |
commit | d6dbf8f9e42692fb409c0ce683b8bde93c43fbe9 (patch) | |
tree | 7dac6ed942194abedbb63e70b3ab6cf0c60cda44 /docs | |
parent | 603abb51499c61f02bbcfc3bfc4112b62907da30 (diff) |
Localise client communication
Since we're communicating with a client that potentially wants to
present our findings to an administrator or even end user to inform them
about what's going on with their email or data, we had German messages
going to the client. Obviously, this is very inconvenient and inflexible
for non-German speakers. Also, it doesn't look very good in the code
base.
Replace static German strings in client communication with English
message ids for internationalisation by gettext. Add an appropriate
German message file. Use the pure-python standard-library gettext module
of python to employ message catalog files. Add the catalog files to
MANIFEST.in for automatic installation into the package by setup.py. Add
Babel as a development dependency to extract messages and update and
compile the catalogs. Add documentation for developers and translators,
how to work with these translations.
Diffstat (limited to 'docs')
-rw-r--r-- | docs/source/config.rst | 4 | ||||
-rw-r--r-- | docs/source/development.rst | 2 | ||||
-rw-r--r-- | docs/source/index.rst | 1 | ||||
-rw-r--r-- | docs/source/l18n.rst | 153 |
4 files changed, 158 insertions, 2 deletions
diff --git a/docs/source/config.rst b/docs/source/config.rst index 70b939e..4fb4629 100644 --- a/docs/source/config.rst +++ b/docs/source/config.rst @@ -133,8 +133,8 @@ Put the following code into ``/etc/amavis/conf.d/15-av_scanners``: @av_scanners = ( ['Peekaboo-Analysis', \&ask_peekaboo, ["{}\n", "/var/run/peekaboo/peekaboo.sock"], - qr/wurde als "(unknown|checked|good|ignored)" eingestuft/m, - qr/wurde als "bad" eingestuft/m ], + qr/has been categorized "(unknown|checked|good|ignored)"$/m, + qr/has been categorized "bad"$/m ], ); 1; # ensure a defined return diff --git a/docs/source/development.rst b/docs/source/development.rst index 5c4367e..7224995 100644 --- a/docs/source/development.rst +++ b/docs/source/development.rst @@ -1,3 +1,5 @@ +.. _development-environment: + ======================= Development Environment ======================= diff --git a/docs/source/index.rst b/docs/source/index.rst index 70358b1..d9b80ea 100644 --- a/docs/source/index.rst +++ b/docs/source/index.rst @@ -28,4 +28,5 @@ For news and announcements follow us on twitter [@peekabooAV](https://twitter.co install config development + l18n :maxdepth: 3 diff --git a/docs/source/l18n.rst b/docs/source/l18n.rst new file mode 100644 index 0000000..c998953 --- /dev/null +++ b/docs/source/l18n.rst @@ -0,0 +1,153 @@ +============= +Translation +============= + +This chapter explains how to translate Peekaboo into other languages. + + +Overview +======== + +Peekaboo has partial internationalization in that it supports translation of +the messages returned to the client into other languages. +The idea is that the client can present these messages to administrators or end +users in their native languages. + +Currently only one language can be statically configured and will be used for +all messages. +Conceivably, the client could communicate the language it wants the report for +an individual analysis to be returned in and we could switch the language on +the fly. +But we currently have no such client and therefore this is not yet implemented. + +The following sections detail how to configure the language to use, translate +existing messages into new languages and how to add new translatable strings. + +Configuration +============= + +By default, Peekaboo uses the system's locale settings which are usually +communicated using environment variables ``LANG`` or ``LC_ALL``. + +As an exception to normal practice, Peekaboo additionally has a configuration +option ``report_locale`` in the ``[global]`` section of its configuration file +to explicitly configure the language used for messages to the client. +This is because it is normally run as a daemon and changing their locale +settings is more complicated than those of user sessions. +Also this is to highlight the fact that Peekaboo only translates messages to +the client and not all its error and debug logging. + +.. _new-languages: + +Translating into new languages +============================== + +Peekaboo uses standard gettext message catalog files. +These are handled using `Babel`_. +They reside in the ``pekaboo/locale`` subdirectory of the source code. + +For translating Peekaboo into a new language, get the source and set up +your :ref:`development-environment`, particularly installing the development +requirements which will give you the ``pybabel`` command. + +Make a new directory ``peekaboo/locale/<new language>/LC_MESSAGES`` and +copy the template ``peekaboo/locale/peekaboo.pot`` into it as +``peekaboo.po`` (note the missing ``t``). + +``<new language>`` in this is a standard locale identifier like ``de`` or +``ca``. +It should be chosen to be generic when starting out and only made more specific +if the translation actually gets that specific, e.g. ``en`` vs. ``en_GB`` +(any English vs. British English). + +Then fill in the empty ``msgstr`` fields with appropriate translations. +When finished, run: + +.. code-block:: shell + + pybabel compile -D peekaboo -d peekaboo/locale + +This will create a ``peekaboo.mo`` file in the same directory which is a +compiled form of the translation. + +The translation can be tested by starting up the debug Peekaboo with with the +``LANG`` environment variable set and submitting a sample for analysis using +``scan_file.py`` in verbose mode like this: + +.. code-block:: shell + + $ LANG=de_DE ./peekaboo_debug.py -c peekaboo.conf + +In another terminal: + +.. code-block:: shell + + $ bin/scan_file.py -s /tmp/peekaboo.sock -f bin/scan_file.py -vv + Waiting for response... + Hallo das ist Peekaboo + + Datei "scan_file.py" 21a76f46ef42a2649d91ad49038a4e239511f4e0b6cd110120348d1d66a130bf wird analysiert + Datei "scan_file.py": Ergebnis "bad" der Regel known - The following signatures have been recognized: One or more processes crashed + , Analyse wird fortgesetzt: Nein. + Die Datei "scan_file.py" wird als "bad" betrachtet + + Die Datensammlung wurde als "bad" eingestuft + The file collection has been categorized "bad" + +**Note**: how the above translation is incomplete: It still says ``The following +signatures ...`` and ``One or more...``. +The second part is easily explained: +Signatures are reported by Cuckoo and aren't translated. +The first part of the message is still in English because in this case the +result was fetched from the database and the Peekaboo instance doing this +analysis was configured to English. + +The above process can be repeated iteratively until all translations are +correct. +Then the new translation file can be sent in for inclusion, e.g. via a Pull +Request on `GitHub`_. + +Adding new translatable messages +================================ + +Messages can be marked as translatable in the source code by enclosing them in +``_()``. +For example: + +.. code-block:: python + + if not self.talk_back(["Hello, this is Peekaboo.", '']): + +turns into: + +.. code-block:: python + + if not self.talk_back([_("Hello, this is Peekaboo."), '']): + +**Note**: Generally, only strings which end up being returned to the client +using method ``talk_back()`` of class ``PeekabooStreamRequestHandler`` should +currently be translated. + +Now the translation template file can be updated with the following ``pybabel`` +command: + +.. code-block:: shell + + $ pybabel extract -o peekaboo/locale/peekaboo.pot bin peekaboo + +With this new template all the translations can be updated to include the new +string for translation: + +.. code-block:: shell + + $ pybabel update -D peekaboo -i peekaboo/locale/peekaboo.pot -d peekaboo/locale + updating catalog peekaboo/locale/de/LC_MESSAGES/peekaboo.po based on peekaboo/locale/peekaboo.pot + +Since the translations are empty, the system will continue to use the +untranslated string. +With the updated files included in the source code, translators can then start +looking into how to translate this string into their language using the normal +process explained under :ref:`new-languages`. + +.. _Babel: http://babel.pocoo.org +.. _GitHub: https://github.com/scVENUS/PeekabooAV |