diff options
author | Arun <engineerarun@gmail.com> | 2024-04-29 18:00:03 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-29 18:00:03 +0530 |
commit | 4c2bb265d0aff43ceaad469d94242eda68eea34d (patch) | |
tree | 78a4c5f2d191a07d854905f521800b37ae146470 | |
parent | 228dd8dbc29a0ef2dcd43d7f64dc535dff4ac7c2 (diff) | |
parent | a03d098e6fb1f6727ec0511327c332c727ae70e9 (diff) |
Merge pull request #733 from LeXofLeviafan/fix-warnings
fix pylint warnings by fixing a test
-rw-r--r-- | bukuserver/api.py | 2 | ||||
-rw-r--r-- | bukuserver/views.py | 2 | ||||
-rw-r--r-- | tests/test_views.py | 3 | ||||
-rw-r--r-- | tox.ini | 4 |
4 files changed, 7 insertions, 4 deletions
diff --git a/bukuserver/api.py b/bukuserver/api.py index afe9684..b36e30a 100644 --- a/bukuserver/api.py +++ b/bukuserver/api.py @@ -228,7 +228,7 @@ class ApiBookmarkSearchView(MethodView): def get(self): arg_obj = request.args - keywords = arg_obj.getlist('keywords') # pylint: disable=E1101 + keywords = arg_obj.getlist('keywords') all_keywords = arg_obj.get('all_keywords') deep = arg_obj.get('deep') regex = arg_obj.get('regex') diff --git a/bukuserver/views.py b/bukuserver/views.py index 0d9cdf1..8f46da1 100644 --- a/bukuserver/views.py +++ b/bukuserver/views.py @@ -68,7 +68,7 @@ def last_page(self): view_args.search, view_args.filters, page_size=page_size) args = request.args.copy() - args.setlist('page', [max(0, (count - 1) // page_size)]) # pylint: disable=E1101 + args.setlist('page', [max(0, (count - 1) // page_size)]) return redirect(url_for('.index_view', **args)) diff --git a/tests/test_views.py b/tests/test_views.py index 982edf3..5b75521 100644 --- a/tests/test_views.py +++ b/tests/test_views.py @@ -7,6 +7,7 @@ from argparse import Namespace import pytest from flask import request from lxml import etree +from werkzeug.datastructures import MultiDict from buku import BukuDb from bukuserver import server @@ -98,7 +99,7 @@ def test_tag_model_view_get_list(tmv_instance, sort_field, sort_desc, filters, e ]) def test_bmv_create_form(bmv_instance, url, backlink, app): with app.test_request_context(): - request.args = {'link': url, 'url': backlink} if backlink else {'link': url} + request.args = MultiDict({'link': url, 'url': backlink} if backlink else {'link': url}) form = bmv_instance.create_form() assert form.url.data == url @@ -80,7 +80,9 @@ commands = [testenv:pylint] basepython = {env:BASEPYTHON:py312} -deps = pylint +deps = + pylint + .[tests] commands = pylint . --rc-file tests/.pylintrc --recursive yes --ignore-paths .tox/,build/,venv/ |