diff options
| author | a1346054 <36859588+a1346054@users.noreply.github.com> | 2021-08-14 11:03:16 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-14 13:03:16 +0200 |
| commit | c62137f8ab4e7a9d033b57e6a77944bb621d90ff (patch) | |
| tree | 84cdd1b40733d09ce7ec49d4bd050a8ebafc8309 | |
| parent | 69c6004681cc9bb2f7126226a86273c136b32756 (diff) | |
Simple maintenance improvements (#1370)
* rofi moved to libera.chat
* unify some theme headers and whitespace
* consistently use the same hashbang for bash
* improve obsolete way of testing equality
see https://github.com/koalaman/shellcheck/wiki/SC2268 for explanation
* use consistent function definitions in bash scripts
* remove duplicated author and fix whitespace
* quote all variables in scripts
fixes many warnings identified through shellcheck
* fix whitespace in scripts
* fix whitespace in non-source files
* fix spelling in non-source files
* fix whitespace and indentation in source files
* fix spelling in source files
113 files changed, 784 insertions, 832 deletions
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 8c128925..3133c348 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -69,10 +69,10 @@ When reporting a feature request include the following information: * A use-case for the feature. If possible try to explain how you would expect to use feature. -For example, should it be a configuration option or a hot-key. +For example, should it be a configuration option or a hot-key. Requesting a feature is no guarantee it will be added. - + **Please do not submit reports related to wayland, see [here](https://github.com/DaveDavenport/rofi/wiki/Wayland) for more information.** diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 57331829..afff87bf 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -7,5 +7,5 @@ contact_links: url: https://www.reddit.com/r/qtools/ about: Please ask and answer questions here. - name: Rofi IRC channel - url: https://webchat.freenode.net/?channels=#rofi + url: https://web.libera.chat/?channels=#rofi about: Please ask and answer question in real time here. diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 36ee0396..9830da93 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -6,7 +6,7 @@ before_script: - apt-get install --force-yes -y autoconf automake make libx11-dev libpango1.0-dev libcairo2-dev libstartup-notification0-dev libxcb-icccm4-dev libxcb-util0-dev libxcb-xinerama0-dev libxcb-xkb-dev libx11-xcb-dev - apt-get install --force-yes -y libxcb1-dev xvfb discount xdotool fluxbox libxkbcommon-dev libxkbcommon-x11-dev libxcb-ewmh-dev xutils-dev libtool lcov libxcb-randr0-dev doxygen python flex bison librsvg2-dev texinfo - git clone --recursive https://github.com/Airblader/xcb-util-xrm.git - - cd xcb-util-xrm + - cd xcb-util-xrm - ./autogen.sh --prefix=/usr - make - sudo make install @@ -34,5 +34,5 @@ build-rofi: artifacts: expire_in: 2 weeks paths: - - coverage + - coverage - doc/html @@ -1,5 +1,5 @@ -Aaron Ash -Adrià Farrés +Aaron Ash +Adrià Farrés Anton Löfgren Avatar bendem @@ -9,7 +9,7 @@ Bruno Braga Buglloc Chris Salzberg daemoni - Dan Beste +Dan Beste Daniel Hahler DanteFireX Dave Davenport @@ -18,9 +18,9 @@ Dimitar Yordanov Edwin Pujols eigengrau Eric Engeström - Fangrui Song +Fangrui Song fice-t - Florian Franzen +Florian Franzen Gabriel Holodak Gareth Poole Georgios Bitzes @@ -44,7 +44,6 @@ N. Izumi Paulo Flabiano Smorigo Peter Cannici qedi -qedi Quentin Glidic Rasmus Steinke Roomcays @@ -139,14 +139,14 @@ v1.5.0: - Fix drun history implementation. (#579) - Add gentoo install instruction. (#685) -v1.4.2: +v1.4.2: - Add sort to manpage. (#682) - Add tranaparent to theme manpage. (#688) - Re-add theme headers. (#679) - Fix super key. (#684) - Unknown option libnkutils:uuid. (#677) - Mode window is not found. (#686) - - Fix meson build in dist file. + - Fix meson build in dist file. v1.4.1: All Hail Rasi - Bump meson release version @@ -233,7 +233,7 @@ v1.3.0: Dan vs. Greg: The never ending story. - Add Control+G for cancel (#452) - Add padding option to textbox (#449) - Ctrl-click does alternate accept entry. (#429) - - Hide window decoration in normal window mode. + - Hide window decoration in normal window mode. - Click to exit option. (#460) - Fix cursor blinking on moving. (#462) - Remove entry from history if fails to execute (#466) @@ -244,16 +244,16 @@ v1.3.0: Dan vs. Greg: The never ending story. - Improve scrollbar behaviour. Removals - opacity option. The transparency support in the theme can do the same and more. - + v1.2.0 New Features - Highlight matched part of the string. - Make window switcher string customizable. Improvements - - Improved selection mode in dmenu with selection counter. + - Improved selection mode in dmenu with selection counter. - Improved selection mode with 'dot' indicator. - Fix Current Desktop window switcher. - - Fix launching in terminal. + - Fix launching in terminal. - Supports include in config. - Add Control+k remove till eol keybinding. - Change clear line to Control+w and make Control+u remove till sol (matching readline) @@ -471,7 +471,7 @@ v1.1.0 - Better way to determine font height. - Fix font vertical centering. - One-off when pasting text. - - Improve rendering of boxes (fixed height and margins) + - Improve rendering of boxes (fixed height and margins) - Fix modi switcher boxes size+layout. - Reduce work on redraws (do not always calculate new size/position), set text, etc. - OO-ify the switchers. diff --git a/Examples/i3_empty_workspace.sh b/Examples/i3_empty_workspace.sh index b4c28dc0..bc27e552 100755 --- a/Examples/i3_empty_workspace.sh +++ b/Examples/i3_empty_workspace.sh @@ -1,10 +1,10 @@ -#!/bin/bash +#!/usr/bin/env bash MAX_DESKTOPS=20 -WORKSPACES=$(seq -s '\n' 1 1 ${MAX_DESKTOPS}) +WORKSPACES=$(seq -s '\n' 1 1 "${MAX_DESKTOPS}") -EMPTY_WORKSPACE=$( (i3-msg -t get_workspaces | tr ',' '\n' | grep num | awk -F: '{print int($2)}' ; \ - echo -e ${WORKSPACES} ) | sort -n | uniq -u | head -n 1) +EMPTY_WORKSPACE=$( (i3-msg -t get_workspaces | tr ',' '\n' | grep num | awk -F: '{print int($2)}' ; \ + echo -e "${WORKSPACES}" ) | sort -n | uniq -u | head -n 1) -i3-msg workspace ${EMPTY_WORKSPACE} +i3-msg workspace "${EMPTY_WORKSPACE}" diff --git a/Examples/i3_switch_workspaces.sh b/Examples/i3_switch_workspaces.sh index a5920567..dd58296c 100755 --- a/Examples/i3_switch_workspaces.sh +++ b/Examples/i3_switch_workspaces.sh @@ -1,18 +1,17 @@ -#!/bin/bash +#!/usr/bin/env bash if [ -z $@ ] then -function gen_workspaces() +gen_workspaces() { i3-msg -t get_workspaces | tr ',' '\n' | grep "name" | sed 's/"name":"\(.*\)"/\1/g' | sort -n } - echo empty; gen_workspaces else WORKSPACE=$@ - if [ |