summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhou Qingyang <zhou1615@umn.edu>2022-04-07 00:48:09 +0800
committerTomas Mraz <tomas@openssl.org>2022-04-21 08:34:34 +0200
commitea5ef33be1bd4fbd89143932a4d12a72003913a5 (patch)
tree174496df3fabe00c3cdd5963d8c02c9a95c6bfde
parentcaf7a9cbcc7462314427c5594c0a50d457bdf3a5 (diff)
Fix a possible NULL pointer dereference in create_cert_store()
In create_cert_store(), X509_STORE_new() is called and there is a dereference of it in following function X509_STORE_add_lookup() without check, which could lead to NULL pointer dereference. Fix this by adding a NULL check of X509_STORE_new() Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18057) (cherry picked from commit 3f075967f664aac12951a1d7aa3124d9235cd299)
-rw-r--r--apps/ts.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/apps/ts.c b/apps/ts.c
index e65d223348..8d1b0893ad 100644
--- a/apps/ts.c
+++ b/apps/ts.c
@@ -976,6 +976,10 @@ static X509_STORE *create_cert_store(const char *CApath, const char *CAfile,
const char *propq = app_get0_propq();
cert_ctx = X509_STORE_new();
+ if (cert_ctx == NULL) {
+ BIO_printf(bio_err, "memory allocation failure\n");
+ return NULL;
+ }
X509_STORE_set_verify_cb(cert_ctx, verify_cb);
if (CApath != NULL) {
lookup = X509_STORE_add_lookup(cert_ctx, X509_LOOKUP_hash_dir());