diff options
| author | Pauli <pauli@openssl.org> | 2021-05-31 14:29:34 +1000 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2021-06-02 16:30:15 +1000 |
| commit | 79cabd7e277ccb0763bd2f6438abcb089dcbdff1 (patch) | |
| tree | 32cfc4c08767d3bfb305083f229ea4a62ee2c5de | |
| parent | c6472fec64d83a196e1ccc4636b552bf0f23addd (diff) | |
rsa: remove TODOs
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)
| -rw-r--r-- | crypto/rsa/rsa_backend.c | 1 | ||||
| -rw-r--r-- | crypto/rsa/rsa_ossl.c | 10 |
2 files changed, 0 insertions, 11 deletions
diff --git a/crypto/rsa/rsa_backend.c b/crypto/rsa/rsa_backend.c index 5b7d60d6e1..e824dcaf3c 100644 --- a/crypto/rsa/rsa_backend.c +++ b/crypto/rsa/rsa_backend.c @@ -270,7 +270,6 @@ int ossl_rsa_pss_params_30_fromdata(RSA_PSS_PARAMS_30 *pss_params, else if (!OSSL_PARAM_get_utf8_ptr(param_mgf, &mgfname)) return 0; - /* TODO Revisit this if / when a new MGF algorithm appears */ if (strcasecmp(param_mgf->data, ossl_rsa_mgf_nid2name(default_maskgenalg_nid)) != 0) return 0; diff --git a/crypto/rsa/rsa_ossl.c b/crypto/rsa/rsa_ossl.c index 1817392e76..c417a4b8f6 100644 --- a/crypto/rsa/rsa_ossl.c +++ b/crypto/rsa/rsa_ossl.c @@ -780,16 +780,6 @@ static int rsa_ossl_mod_exp(BIGNUM *r0, const BIGNUM *I, RSA *rsa, BN_CTX *ctx) } #ifndef FIPS_MODULE - /* - * calculate m_i in multi-prime case - * - * TODO: - * 1. squash the following two loops and calculate |m_i| there. - * 2. remove cc and reuse |c|. - * 3. remove |dmq1| and |dmp1| in previous block and use |di|. - * - * If these things are done, the code will be more readable. - */ if (ex_primes > 0) { BIGNUM *di = BN_new(), *cc = BN_new(); |