summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDominique Martinet <asmadeus@codewreck.org>2020-11-26 14:26:57 +0100
committerDominique Martinet <asmadeus@codewreck.org>2020-11-26 14:26:57 +0100
commit1fd13d67e85b8365baed1cfb435870e24a7e6979 (patch)
treeda9786a10336d3dac0cd910712c6b7e88118ca1f
parent8252a44e96619b6df0901a1f62e60b3d5951fd12 (diff)
archive: disable preallocate-contents by default
using fallocate() to preallocate files space does more harm than good: - breaks compression on btrfs - has been called "not the right thing to do" by xfs developers (because delayed allocation that most filesystems implement leads to smarter allocation than what the filesystem needs to do if we upfront fallocate files)
-rw-r--r--src/libutil/archive.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libutil/archive.cc b/src/libutil/archive.cc
index f1479329f..03534abc4 100644
--- a/src/libutil/archive.cc
+++ b/src/libutil/archive.cc
@@ -27,7 +27,7 @@ struct ArchiveSettings : Config
#endif
"use-case-hack",
"Whether to enable a Darwin-specific hack for dealing with file name collisions."};
- Setting<bool> preallocateContents{this, true, "preallocate-contents",
+ Setting<bool> preallocateContents{this, false, "preallocate-contents",
"Whether to preallocate files when writing objects with known size."};
};