diff options
author | Paul Tirk <paultirk@paultirk.com> | 2021-03-25 18:23:12 +0100 |
---|---|---|
committer | Sean Molenaar <SMillerDev@users.noreply.github.com> | 2021-04-08 10:23:11 +0200 |
commit | 8b3c1341e8d7da94e95c47f3695dc36b693fb333 (patch) | |
tree | b7431312e813046140a59bc77fb6a6e7eba6a7e1 | |
parent | 9db82b19a533af59bb4142bf3f531490c962e444 (diff) |
return error if new folder name is missing on update
Signed-off-by: Paul Tirk <paultirk@paultirk.com>
-rw-r--r-- | lib/Controller/FolderApiV2Controller.php | 4 | ||||
-rw-r--r-- | tests/Unit/Controller/FolderApiV2ControllerTest.php | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/Controller/FolderApiV2Controller.php b/lib/Controller/FolderApiV2Controller.php index e849f1cbc..d8ad21fe6 100644 --- a/lib/Controller/FolderApiV2Controller.php +++ b/lib/Controller/FolderApiV2Controller.php @@ -72,6 +72,10 @@ class FolderApiV2Controller extends ApiController */ public function update($folderId, $name) { + if (empty($name)) { + return $this->errorResponseV2('folder name is empty', 1, Http::STATUS_BAD_REQUEST); + } + $response = null; try { $response = $this->folderService->rename($this->getUserId(), $folderId, $name); diff --git a/tests/Unit/Controller/FolderApiV2ControllerTest.php b/tests/Unit/Controller/FolderApiV2ControllerTest.php index 0799567bf..35f4ab951 100644 --- a/tests/Unit/Controller/FolderApiV2ControllerTest.php +++ b/tests/Unit/Controller/FolderApiV2ControllerTest.php @@ -191,13 +191,17 @@ class FolderApiV2ControllerTest extends TestCase public function testUpdateInvalidFolderName() { + $msg = 'folder name is empty'; + $code = 1; + $folderId = 23; $folderName = ''; $response = $this->folderAPI->update($folderId, $folderName); $data = $response->getData(); - $this->assertEquals($this->msg, $data['error']['message']); + $this->assertEquals($msg, $data['error']['message']); + $this->assertEquals($code, $data['error']['code']); $this->assertEquals(Http::STATUS_BAD_REQUEST, $response->getStatus()); } } |