diff options
| author | Timotej S <6674623+underhood@users.noreply.github.com> | 2023-05-15 22:18:11 +0200 |
|---|---|---|
| committer | Austin S. Hemmelgarn <austin@netdata.cloud> | 2023-05-16 08:06:07 -0400 |
| commit | 8b5cf99a2e76085c386e926904d3a07f8a8537bb (patch) | |
| tree | b8584eb0a4a2a9a76443d7d9f090b75c63ed8b6e | |
| parent | a865bde2665faf9068c8fb90143c860f879a1561 (diff) | |
Fix ACLK memleak (#15055)
* fix memleak
* minor simplify
| -rw-r--r-- | aclk/aclk_tx_msgs.c | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/aclk/aclk_tx_msgs.c b/aclk/aclk_tx_msgs.c index 532b964ad3..86ee818edc 100644 --- a/aclk/aclk_tx_msgs.c +++ b/aclk/aclk_tx_msgs.c @@ -51,13 +51,6 @@ uint16_t aclk_send_bin_message_subtopic_pid(mqtt_wss_client client, char *msg, s return packet_id; } -// json_object_put returns int unfortunately :D -// we need void(*fnc)(void *); -static void json_object_put_wrapper(void *jsonobj) -{ - json_object_put(jsonobj); -} - #define TOPIC_MAX_LEN 512 #define V2_BIN_PAYLOAD_SEPARATOR "\x0D\x0A\x0D\x0A" static int aclk_send_message_with_bin_payload(mqtt_wss_client client, json_object *msg, const char *topic, const void *payload, size_t payload_len) @@ -76,19 +69,21 @@ static int aclk_send_message_with_bin_payload(mqtt_wss_client client, json_objec str = json_object_to_json_string_ext(msg, JSON_C_TO_STRING_PLAIN); len = strlen(str); - if (payload_len) { - full_msg = mallocz(len + strlen(V2_BIN_PAYLOAD_SEPARATOR) + payload_len); + size_t full_msg_len = len; + if (payload_len) + full_msg_len += strlen(V2_BIN_PAYLOAD_SEPARATOR) + payload_len; - memcpy(full_msg, str, len); - json_object_put(msg); - msg = NULL; + full_msg = mallocz(full_msg_len); + memcpy(full_msg, str, len); + json_object_put(msg); + + if (payload_len) { memcpy(&full_msg[len], V2_BIN_PAYLOAD_SEPARATOR, strlen(V2_BIN_PAYLOAD_SEPARATOR)); len += strlen(V2_BIN_PAYLOAD_SEPARATOR); memcpy(&full_msg[len], payload, payload_len); - len += payload_len; } - mqtt_wss_publish5(client, (char*)topic, NULL, (char*)(payload_len ? full_msg : str), (payload_len ? &freez_aclk_publish5b : &json_object_put_wrapper), len, MQTT_WSS_PUB_QOS1, &packet_id); + mqtt_wss_publish5(client, (char*)topic, NULL, full_msg, &freez_aclk_publish5b, full_msg_len, MQTT_WSS_PUB_QOS1, &packet_id); #ifdef NETDATA_INTERNAL_CHECKS aclk_stats_msg_published(packet_id); |