Make all single argument constructors explicit

10 files changed, 11 insertions, 10 deletions

diff --git a/src/controllers/bulk/bulkenumerator.h b/src/controllers/bulk/bulkenumerator.h
index 2018a4a118..effd0044d6 100644
--- a/src/controllers/bulk/bulkenumerator.h
+++ b/src/controllers/bulk/bulkenumerator.h
@@ -14,7 +14,7 @@ struct libusb_context;
 
 class BulkEnumerator : public ControllerEnumerator {
   public:
-    BulkEnumerator(UserSettingsPointer pConfig);
+    explicit BulkEnumerator(UserSettingsPointer pConfig);
     virtual ~BulkEnumerator();
 
     QList<Controller*> queryDevices();
diff --git a/src/controllers/controller.h b/src/controllers/controller.h
index a1c1a8c020..09a20d8181 100644
--- a/src/controllers/controller.h
+++ b/src/controllers/controller.h
@@ -23,7 +23,7 @@
 class Controller : public QObject, ConstControllerPresetVisitor {
     Q_OBJECT
   public:
-    Controller(UserSettingsPointer pConfig);
+    explicit Controller(UserSettingsPointer pConfig);
     ~Controller() override;  // Subclass should call close() at minimum.
 
     // Returns the extension for the controller (type) preset files.  This is
diff --git a/src/controllers/hid/hidenumerator.h b/src/controllers/hid/hidenumerator.h
index 9b39b75c94..a61490f1ab 100644
--- a/src/controllers/hid/hidenumerator.h
+++ b/src/controllers/hid/hidenumerator.h
@@ -12,7 +12,7 @@
 
 class HidEnumerator : public ControllerEnumerator {
   public:
-    HidEnumerator(UserSettingsPointer pConfig);
+    explicit HidEnumerator(UserSettingsPointer pConfig);
     virtual ~HidEnumerator();
 
     QList<Controller*> queryDevices();
diff --git a/src/controllers/midi/hss1394enumerator.h b/src/controllers/midi/hss1394enumerator.h
index 78d581425f..184fcfb233 100644
--- a/src/controllers/midi/hss1394enumerator.h
+++ b/src/controllers/midi/hss1394enumerator.h
@@ -13,7 +13,7 @@
 class Hss1394Enumerator : public MidiEnumerator {
     Q_OBJECT
   public:
-    Hss1394Enumerator(UserSettingsPointer pConfig);
+    explicit Hss1394Enumerator(UserSettingsPointer pConfig);
     virtual ~Hss1394Enumerator();
 
     QList<Controller*> queryDevices();
diff --git a/src/controllers/midi/midicontroller.h b/src/controllers/midi/midicontroller.h
index b8ebb8b94b..a81ff7d680 100644
--- a/src/controllers/midi/midicontroller.h
+++ b/src/controllers/midi/midicontroller.h
@@ -23,7 +23,7 @@
 class MidiController : public Controller {
     Q_OBJECT
   public:
-    MidiController(UserSettingsPointer pConfig);
+    explicit MidiController(UserSettingsPointer pConfig);
     ~MidiController() override;
 
     QString presetExtension() override;
diff --git a/src/controllers/midi/portmidienumerator.h b/src/controllers/midi/portmidienumerator.h
index 9566b54df1..5169efbfa0 100644
--- a/src/controllers/midi/portmidienumerator.h
+++ b/src/controllers/midi/portmidienumerator.h
@@ -13,7 +13,7 @@
 class PortMidiEnumerator : public MidiEnumerator {
     Q_OBJECT
   public:
-    PortMidiEnumerator(UserSettingsPointer pConfig);
+    explicit PortMidiEnumerator(UserSettingsPointer pConfig);
     virtual ~PortMidiEnumerator();
 
     QList<Controller*> queryDevices();
diff --git a/src/preferences/colorpalettesettings.cpp b/src/preferences/colorpalettesettings.cpp
index a676265016..b2af4d1293 100644
--- a/src/preferences/colorpalettesettings.cpp
+++ b/src/preferences/colorpalettesettings.cpp
@@ -16,7 +16,7 @@ ColorPalette ColorPaletteSettings::getColorPalette(
         return defaultPalette;
     }
 
-    return colorList;
+    return ColorPalette(colorList);
 }
 
 void ColorPaletteSettings::setColorPalette(
diff --git a/src/test/controller_preset_validation_test.cpp b/src/test/controller_preset_validation_test.cpp
index 970cf0158c..a1a65f4015 100644
--- a/src/test/controller_preset_validation_test.cpp
+++ b/src/test/controller_preset_validation_test.cpp
@@ -15,7 +15,7 @@
 
 class FakeController : public Controller {
   public:
-    FakeController(UserSettingsPointer pConfig);
+    explicit FakeController(UserSettingsPointer pConfig);
     ~FakeController() override;
 
     QString presetExtension() override {
diff --git a/src/test/midicontrollertest.cpp b/src/test/midicontrollertest.cpp
index 0d10c4c54a..ac52090863 100644
--- a/src/test/midicontrollertest.cpp
+++ b/src/test/midicontrollertest.cpp
@@ -12,7 +12,8 @@
 
 class MockMidiController : public MidiController {
   public:
-    MockMidiController(UserSettingsPointer pConfig) : MidiController(pConfig) {
+    explicit MockMidiController(UserSettingsPointer pConfig)
+            : MidiController(pConfig) {
     }
     ~MockMidiController() override { }
 
diff --git a/src/util/color/colorpalette.h b/src/util/color/colorpalette.h
index dc865980bb..8f92b436fa 100644
--- a/src/util/color/colorpalette.h
+++ b/src/util/color/colorpalette.h
@@ -6,7 +6,7 @@
 
 class ColorPalette {
   public:
-    ColorPalette(QList<mixxx::RgbColor> colorList)
+    explicit ColorPalette(QList<mixxx::RgbColor> colorList)
             : m_colorList(colorList) {
         DEBUG_ASSERT(m_colorList.size() != 0);
     }