diff options
| author | Jason Wang <jasowang@redhat.com> | 2018-02-24 11:32:26 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-26 13:49:49 -0500 |
| commit | 1bb4f2e868a2891ab8bc668b8173d6ccb8c4ce6f (patch) | |
| tree | 8962cd92d2fc5c8c323fa5d0fccdf18c1638e26b | |
| parent | 23e43f07f896f8578318cfcc9466f1e8b8ab21b6 (diff) | |
tuntap: correctly add the missing XDP flush
We don't flush batched XDP packets through xdp_do_flush_map(), this
will cause packets stall at TX queue. Consider we don't do XDP on NAPI
poll(), the only possible fix is to call xdp_do_flush_map()
immediately after xdp_do_redirect().
Note, this in fact won't try to batch packets through devmap, we could
address in the future.
Reported-by: Christoffer Dall <christoffer.dall@linaro.org>
Fixes: 761876c857cb ("tap: XDP support")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/tun.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 63d39fe67b99..7433bb2e4451 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1663,6 +1663,7 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun, get_page(alloc_frag->page); alloc_frag->offset += buflen; err = xdp_do_redirect(tun->dev, &xdp, xdp_prog); + xdp_do_flush_map(); if (err) goto err_redirect; rcu_read_unlock(); |