summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesse Duffield <jessedduffield@gmail.com>2024-01-26 10:03:04 +1100
committerJesse Duffield <jessedduffield@gmail.com>2024-01-28 08:33:13 +1100
commit1a38d515d78ceb60c2f88813c2c3ba8708315e48 (patch)
tree7b0251ccd44b5caf7e05b9dc176edca10ff017d1
parent0f9d9e13d12d37ab419efccc5c217422fb67a765 (diff)
Display more keybindings on-screen
-rw-r--r--pkg/gui/controllers/basic_commits_controller.go3
-rw-r--r--pkg/gui/controllers/branches_controller.go15
-rw-r--r--pkg/gui/controllers/commits_files_controller.go4
-rw-r--r--pkg/gui/controllers/files_controller.go32
-rw-r--r--pkg/gui/controllers/local_commits_controller.go32
-rw-r--r--pkg/gui/controllers/merge_conflicts_controller.go28
-rw-r--r--pkg/gui/controllers/patch_building_controller.go7
-rw-r--r--pkg/gui/controllers/patch_explorer_controller.go9
-rw-r--r--pkg/gui/controllers/remote_branches_controller.go5
-rw-r--r--pkg/gui/controllers/remotes_controller.go11
-rw-r--r--pkg/gui/controllers/staging_controller.go27
-rw-r--r--pkg/gui/controllers/stash_controller.go3
-rw-r--r--pkg/gui/controllers/status_controller.go23
-rw-r--r--pkg/gui/controllers/submodules_controller.go10
-rw-r--r--pkg/gui/controllers/tags_controller.go13
-rw-r--r--pkg/gui/controllers/worktrees_controller.go9
16 files changed, 151 insertions, 80 deletions
diff --git a/pkg/gui/controllers/basic_commits_controller.go b/pkg/gui/controllers/basic_commits_controller.go
index c62818df9..45239ef68 100644
--- a/pkg/gui/controllers/basic_commits_controller.go
+++ b/pkg/gui/controllers/basic_commits_controller.go
@@ -52,6 +52,7 @@ func (self *BasicCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Checkout,
Tooltip: self.c.Tr.CheckoutCommitTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.CopyCommitAttributeToClipboard),
@@ -80,6 +81,7 @@ func (self *BasicCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
Description: self.c.Tr.ViewResetOptions,
Tooltip: self.c.Tr.ResetTooltip,
OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.CherryPickCopy),
@@ -91,6 +93,7 @@ func (self *BasicCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
"escape": keybindings.Label(opts.Config.Universal.Return),
},
),
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.ResetCherryPick),
diff --git a/pkg/gui/controllers/branches_controller.go b/pkg/gui/controllers/branches_controller.go
index 002aca4fb..068238ec7 100644
--- a/pkg/gui/controllers/branches_controller.go
+++ b/pkg/gui/controllers/branches_controller.go
@@ -47,14 +47,16 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
self.singleItemSelected(),
self.notPulling,
),
- Description: self.c.Tr.Checkout,
- Tooltip: self.c.Tr.CheckoutTooltip,
+ Description: self.c.Tr.Checkout,
+ Tooltip: self.c.Tr.CheckoutTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.New),
Handler: self.withItem(self.newBranch),
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.NewBranch,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.CreatePullRequest),
@@ -95,6 +97,7 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
Description: self.c.Tr.Delete,
Tooltip: self.c.Tr.BranchDeleteTooltip,
OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.RebaseBranch),
@@ -102,8 +105,9 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
GetDisabledReason: self.require(
self.singleItemSelected(self.notRebasingOntoSelf),
),
- Description: self.c.Tr.RebaseBranch,
- Tooltip: self.c.Tr.RebaseBranchTooltip,
+ Description: self.c.Tr.RebaseBranch,
+ Tooltip: self.c.Tr.RebaseBranchTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.MergeIntoCurrentBranch),
@@ -111,6 +115,7 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Merge,
Tooltip: self.c.Tr.MergeBranchTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.FastForward),
@@ -136,6 +141,7 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.ViewResetOptions,
OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.RenameBranch),
@@ -151,6 +157,7 @@ func (self *BranchesController) GetKeybindings(opts types.KeybindingsOpts) []*ty
Tooltip: self.c.Tr.ViewBranchUpstreamOptionsTooltip,
ShortDescription: self.c.Tr.Upstream,
OpensMenu: true,
+ DisplayOnScreen: true,
},
}
}
diff --git a/pkg/gui/controllers/commits_files_controller.go b/pkg/gui/controllers/commits_files_controller.go
index 3ff1e50e3..e2ed4b3f0 100644
--- a/pkg/gui/controllers/commits_files_controller.go
+++ b/pkg/gui/controllers/commits_files_controller.go
@@ -43,6 +43,7 @@ func (self *CommitFilesController) GetKeybindings(opts types.KeybindingsOpts) []
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Checkout,
Tooltip: self.c.Tr.CheckoutCommitFileTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Remove),
@@ -50,6 +51,7 @@ func (self *CommitFilesController) GetKeybindings(opts types.KeybindingsOpts) []
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Remove,
Tooltip: self.c.Tr.DiscardOldFileChangeTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.OpenFile),
@@ -64,6 +66,7 @@ func (self *CommitFilesController) GetKeybindings(opts types.KeybindingsOpts) []
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Edit,
Tooltip: self.c.Tr.EditFileTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.OpenDiffTool),
@@ -79,6 +82,7 @@ func (self *CommitFilesController) GetKeybindings(opts types.KeybindingsOpts) []
Tooltip: utils.ResolvePlaceholderString(self.c.Tr.ToggleAddToPatchTooltip,
map[string]string{"doc": constants.Links.Docs.CustomPatchDemo},
),
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Files.ToggleStagedAll),
diff --git a/pkg/gui/controllers/files_controller.go b/pkg/gui/controllers/files_controller.go
index c450b6fe9..504617218 100644
--- a/pkg/gui/controllers/files_controller.go
+++ b/pkg/gui/controllers/files_controller.go
@@ -43,6 +43,7 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
GetDisabledReason: self.require(self.itemsSelected()),
Description: self.c.Tr.Stage,
Tooltip: self.c.Tr.StageTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Files.OpenStatusFilter),
@@ -56,10 +57,11 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
OpensMenu: true,
},
{
- Key: opts.GetKey(opts.Config.Files.CommitChanges),
- Handler: self.c.Helpers().WorkingTree.HandleCommitPress,
- Description: self.c.Tr.Commit,
- Tooltip: self.c.Tr.CommitTooltip,
+ Key: opts.GetKey(opts.Config.Files.CommitChanges),
+ Handler: self.c.Helpers().WorkingTree.HandleCommitPress,
+ Description: self.c.Tr.Commit,
+ Tooltip: self.c.Tr.CommitTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Files.CommitChangesWithoutHook),
@@ -88,6 +90,7 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Edit,
Tooltip: self.c.Tr.EditFileTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.OpenFile),
@@ -109,10 +112,11 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
Description: self.c.Tr.RefreshFiles,
},
{
- Key: opts.GetKey(opts.Config.Files.StashAllChanges),
- Handler: self.stash,
- Description: self.c.Tr.Stash,
- Tooltip: self.c.Tr.StashTooltip,
+ Key: opts.GetKey(opts.Config.Files.StashAllChanges),
+ Handler: self.stash,
+ Description: self.c.Tr.Stash,
+ Tooltip: self.c.Tr.StashTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Files.ViewStashOptions),
@@ -141,6 +145,7 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
Description: self.c.Tr.Discard,
Tooltip: self.c.Tr.DiscardFileChangesTooltip,
OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.ViewResetOptions),
@@ -149,11 +154,12 @@ func (self *FilesController) GetKeybindings(opts types.KeybindingsOpts) []*types
OpensMenu: true,
},
{
- Key: opts.GetKey(opts.Config.Files.ViewResetOptions),
- Handler: self.createResetMenu,
- Description: self.c.Tr.Reset,
- Tooltip: self.c.Tr.FileResetOptionsTooltip,
- OpensMenu: true,
+ Key: opts.GetKey(opts.Config.Files.ViewResetOptions),
+ Handler: self.createResetMenu,
+ Description: self.c.Tr.Reset,
+ Tooltip: self.c.Tr.FileResetOptionsTooltip,
+ OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Files.ToggleTreeView),
diff --git a/pkg/gui/controllers/local_commits_controller.go b/pkg/gui/controllers/local_commits_controller.go
index 25abd2c85..3dc1bae7f 100644
--- a/pkg/gui/controllers/local_commits_controller.go
+++ b/pkg/gui/controllers/local_commits_controller.go
@@ -64,8 +64,9 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
self.canSquashOrFixup,
),
),
- Description: self.c.Tr.Squash,
- Tooltip: self.c.Tr.SquashTooltip,
+ Description: self.c.Tr.Squash,
+ Tooltip: self.c.Tr.SquashTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.MarkCommitAsFixup),
@@ -76,8 +77,9 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
self.canSquashOrFixup,
),
),
- Description: self.c.Tr.Fixup,
- Tooltip: self.c.Tr.FixupTooltip,
+ Description: self.c.Tr.Fixup,
+ Tooltip: self.c.Tr.FixupTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.RenameCommit),
@@ -85,9 +87,10 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
GetDisabledReason: self.require(
self.singleItemSelected(self.rewordEnabled),
),
- Description: self.c.Tr.Reword,
- Tooltip: self.c.Tr.CommitRewordTooltip,
- OpensMenu: true,
+ Description: self.c.Tr.Reword,
+ Tooltip: self.c.Tr.CommitRewordTooltip,
+ DisplayOnScreen: true,
+ OpensMenu: true,
},
{
Key: opts.GetKey(opts.Config.Commits.RenameCommitWithEditor),
@@ -105,8 +108,9 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
self.midRebaseCommandEnabled,
),
),
- Description: self.c.Tr.DropCommit,
- Tooltip: self.c.Tr.DropCommitTooltip,
+ Description: self.c.Tr.DropCommit,
+ Tooltip: self.c.Tr.DropCommitTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(editCommitKey),
@@ -118,6 +122,7 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
Description: self.c.Tr.EditCommit,
ShortDescription: self.c.Tr.Edit,
Tooltip: self.c.Tr.EditCommitTooltip,
+ DisplayOnScreen: true,
},
{
// The user-facing description here is 'Start interactive rebase' but internally
@@ -139,6 +144,14 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
),
Description: self.c.Tr.Pick,
Tooltip: self.c.Tr.PickCommitTooltip,
+ // Not displaying this because we only want to display it when a TODO commit
+ // is selected. A keybinding is displayed in the options view if Display is true,
+ // and if it's not disabled, but if we disable it whenever a non-TODO commit is
+ // selected, we'll be preventing pulls from happening within the commits view
+ // (given they both use the 'p' key). Some approaches that come to mind:
+ // * Allow a disabled keybinding to conditionally fallback to a global keybinding
+ // * Allow a separate way of deciding whether a keybinding is displayed in the options view
+ DisplayOnScreen: false,
},
{
Key: opts.GetKey(opts.Config.Commits.CreateFixupCommit),
@@ -221,6 +234,7 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
GetDisabledReason: self.require(self.singleItemSelected(self.canAmend)),
Description: self.c.Tr.Amend,
Tooltip: self.c.Tr.AmendCommitTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.ResetCommitAuthor),
diff --git a/pkg/gui/controllers/merge_conflicts_controller.go b/pkg/gui/controllers/merge_conflicts_controller.go
index 03ca4a10b..1f22e62bc 100644
--- a/pkg/gui/controllers/merge_conflicts_controller.go
+++ b/pkg/gui/controllers/merge_conflicts_controller.go
@@ -28,24 +28,28 @@ func NewMergeConflictsController(
func (self *MergeConflictsController) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
bindings := []*types.Binding{
{
- Key: opts.GetKey(opts.Config.Universal.Select),
- Handler: self.withRenderAndFocus(self.HandlePickHunk),
- Description: self.c.Tr.PickHunk,
+ Key: opts.GetKey(opts.Config.Universal.Select),
+ Handler: self.withRenderAndFocus(self.HandlePickHunk),
+ Description: self.c.Tr.PickHunk,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Main.PickBothHunks),
- Handler: self.withRenderAndFocus(self.HandlePickAllHunks),
- Description: self.c.Tr.PickAllHunks,
+ Key: opts.GetKey(opts.Config.Main.PickBothHunks),
+ Handler: self.withRenderAndFocus(self.HandlePickAllHunks),
+ Description: self.c.Tr.PickAllHunks,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.PrevItem),
- Handler: self.withRenderAndFocus(self.PrevConflictHunk),
- Description: self.c.Tr.SelectPrevHunk,
+ Key: opts.GetKey(opts.Config.Universal.PrevItem),
+ Handler: self.withRenderAndFocus(self.PrevConflictHunk),
+ Description: self.c.Tr.SelectPrevHunk,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.NextItem),
- Handler: self.withRenderAndFocus(self.NextConflictHunk),
- Description: self.c.Tr.SelectNextHunk,
+ Key: opts.GetKey(opts.Config.Universal.NextItem),
+ Handler: self.withRenderAndFocus(self.NextConflictHunk),
+ Description: self.c.Tr.SelectNextHunk,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.PrevBlock),
diff --git a/pkg/gui/controllers/patch_building_controller.go b/pkg/gui/controllers/patch_building_controller.go
index c5141a20e..dbbdb8beb 100644
--- a/pkg/gui/controllers/patch_building_controller.go
+++ b/pkg/gui/controllers/patch_building_controller.go
@@ -37,9 +37,10 @@ func (self *PatchBuildingController) GetKeybindings(opts types.KeybindingsOpts)
Tooltip: self.c.Tr.EditFileTooltip,
},
{
- Key: opts.GetKey(opts.Config.Universal.Select),
- Handler: self.ToggleSelectionAndRefresh,
- Description: self.c.Tr.ToggleSelectionForPatch,
+ Key: opts.GetKey(opts.Config.Universal.Select),
+ Handler: self.ToggleSelectionAndRefresh,
+ Description: self.c.Tr.ToggleSelectionForPatch,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Return),
diff --git a/pkg/gui/controllers/patch_explorer_controller.go b/pkg/gui/controllers/patch_explorer_controller.go
index 1f6ef97dd..9d736df10 100644
--- a/pkg/gui/controllers/patch_explorer_controller.go
+++ b/pkg/gui/controllers/patch_explorer_controller.go
@@ -92,10 +92,11 @@ func (self *PatchExplorerController) GetKeybindings(opts types.KeybindingsOpts)
Description: self.c.Tr.ToggleRangeSelect,
},
{
- Key: opts.GetKey(opts.Config.Main.ToggleSelectHunk),
- Handler: self.withRenderAndFocus(self.HandleToggleSelectHunk),
- Description: self.c.Tr.ToggleSelectHunk,
- Tooltip: self.c.Tr.ToggleSelectHunkTooltip,
+ Key: opts.GetKey(opts.Config.Main.ToggleSelectHunk),
+ Handler: self.withRenderAndFocus(self.HandleToggleSelectHunk),
+ Description: self.c.Tr.ToggleSelectHunk,
+ Tooltip: self.c.Tr.ToggleSelectHunkTooltip,
+ DisplayOnScreen: true,
},
{
Tag: "navigation",
diff --git a/pkg/gui/controllers/remote_branches_controller.go b/pkg/gui/controllers/remote_branches_controller.go
index f4998ef28..0cfdfbcd5 100644
--- a/pkg/gui/controllers/remote_branches_controller.go
+++ b/pkg/gui/controllers/remote_branches_controller.go
@@ -41,6 +41,7 @@ func (self *RemoteBranchesController) GetKeybindings(opts types.KeybindingsOpts)
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Checkout,
Tooltip: self.c.Tr.RemoteBranchCheckoutTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.New),
@@ -54,6 +55,7 @@ func (self *RemoteBranchesController) GetKeybindings(opts types.KeybindingsOpts)
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Merge,
Tooltip: self.c.Tr.MergeBranchTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.RebaseBranch),
@@ -61,6 +63,7 @@ func (self *RemoteBranchesController) GetKeybindings(opts types.KeybindingsOpts)
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.RebaseBranch,
Tooltip: self.c.Tr.RebaseBranchTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Remove),
@@ -68,6 +71,7 @@ func (self *RemoteBranchesController) GetKeybindings(opts types.KeybindingsOpts)
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Delete,
Tooltip: self.c.Tr.DeleteRemoteBranchTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.SetUpstream),
@@ -75,6 +79,7 @@ func (self *RemoteBranchesController) GetKeybindings(opts types.KeybindingsOpts)
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.SetAsUpstream,
Tooltip: self.c.Tr.SetAsUpstreamTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.SortOrder),
diff --git a/pkg/gui/controllers/remotes_controller.go b/pkg/gui/controllers/remotes_controller.go
index 82e3db0e6..37c1273ed 100644
--- a/pkg/gui/controllers/remotes_controller.go
+++ b/pkg/gui/controllers/remotes_controller.go
@@ -46,11 +46,13 @@ func (self *RemotesController) GetKeybindings(opts types.KeybindingsOpts) []*typ
Handler: self.withItem(self.enter),
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.ViewBranches,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.New),
- Handler: self.add,
- Description: self.c.Tr.NewRemote,
+ Key: opts.GetKey(opts.Config.Universal.New),
+ Handler: self.add,
+ Description: self.c.Tr.NewRemote,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Remove),
@@ -58,6 +60,7 @@ func (self *RemotesController) GetKeybindings(opts types.KeybindingsOpts) []*typ
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Remove,
Tooltip: self.c.Tr.RemoveRemoteTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Edit),
@@ -65,6 +68,7 @@ func (self *RemotesController) GetKeybindings(opts types.KeybindingsOpts) []*typ
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Edit,
Tooltip: self.c.Tr.EditRemoteTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.FetchRemote),
@@ -72,6 +76,7 @@ func (self *RemotesController) GetKeybindings(opts types.KeybindingsOpts) []*typ
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Fetch,
Tooltip: self.c.Tr.FetchRemoteTooltip,
+ DisplayOnScreen: true,
},
}
diff --git a/pkg/gui/controllers/staging_controller.go b/pkg/gui/controllers/staging_controller.go
index d00f71d9b..13d896be8 100644
--- a/pkg/gui/controllers/staging_controller.go
+++ b/pkg/gui/controllers/staging_controller.go
@@ -40,16 +40,18 @@ func NewStagingController(
func (self *StagingController) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
return []*types.Binding{
{
- Key: opts.GetKey(opts.Config.Universal.Select),
- Handler: self.ToggleStaged,
- Description: self.c.Tr.Stage,
- Tooltip: self.c.Tr.StageSelectionTooltip,
+ Key: opts.GetKey(opts.Config.Universal.Select),
+ Handler: self.ToggleStaged,
+ Description: self.c.Tr.Stage,
+ Tooltip: self.c.Tr.StageSelectionTooltip,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.Remove),
- Handler: self.DiscardSelection,
- Description: self.c.Tr.DiscardSelection,
- Tooltip: self.c.Tr.DiscardSelectionTooltip,
+ Key: opts.GetKey(opts.Config.Universal.Remove),
+ Handler: self.DiscardSelection,
+ Description: self.c.Tr.DiscardSelection,
+ Tooltip: self.c.Tr.DiscardSelectionTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.OpenFile),
@@ -69,10 +71,11 @@ func (self *StagingController) GetKeybindings(opts types.KeybindingsOpts) []*typ
Description: self.c.Tr.ReturnToFilesPanel,
},
{
- Key: opts.GetKey(opts.Config.Universal.TogglePanel),
- Handler: self.TogglePanel,
- Description: self.c.Tr.ToggleStagingView,
- Tooltip: self.c.Tr.ToggleStagingViewTooltip,
+ Key: opts.GetKey(opts.Config.Universal.TogglePanel),
+ Handler: self.TogglePanel,
+ Description: self.c.Tr.ToggleStagingView,
+ Tooltip: self.c.Tr.ToggleStagingViewTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Main.EditSelectHunk),
diff --git a/pkg/gui/controllers/stash_controller.go b/pkg/gui/controllers/stash_controller.go
index 21e4f9cda..8b5e068b5 100644
--- a/pkg/gui/controllers/stash_controller.go
+++ b/pkg/gui/controllers/stash_controller.go
@@ -38,6 +38,7 @@ func (self *StashController) GetKeybindings(opts types.KeybindingsOpts) []*types
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Apply,
Tooltip: self.c.Tr.StashApplyTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Stash.PopStash),
@@ -45,6 +46,7 @@ func (self *StashController) GetKeybindings(opts types.KeybindingsOpts) []*types
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Pop,
Tooltip: self.c.Tr.StashPopTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Remove),
@@ -52,6 +54,7 @@ func (self *StashController) GetKeybindings(opts types.KeybindingsOpts) []*types
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Drop,
Tooltip: self.c.Tr.StashDropTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.New),
diff --git a/pkg/gui/controllers/status_controller.go b/pkg/gui/controllers/status_controller.go
index a1addf1c0..f5672ce64 100644
--- a/pkg/gui/controllers/status_controller.go
+++ b/pkg/gui/controllers/status_controller.go
@@ -39,20 +39,23 @@ func (self *StatusController) GetKeybindings(opts types.KeybindingsOpts) []*type
Tooltip: self.c.Tr.OpenFileTooltip,
},
{
- Key: opts.GetKey(opts.Config.Universal.Edit),
- Handler: self.editConfig,
- Description: self.c.Tr.EditConfig,
- Tooltip: self.c.Tr.EditFileTooltip,
+ Key: opts.GetKey(opts.Config.Universal.Edit),
+ Handler: self.editConfig,
+ Description: self.c.Tr.EditConfig,
+ Tooltip: self.c.Tr.EditFileTooltip,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Status.CheckForUpdate),
- Handler: self.handleCheckForUpdate,
- Description: self.c.Tr.CheckForUpdate,
+ Key: opts.GetKey(opts.Config.Status.CheckForUpdate),
+ Handler: self.handleCheckForUpdate,
+ Description: self.c.Tr.CheckForUpdate,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Status.RecentRepos),
- Handler: self.c.Helpers().Repos.CreateRecentReposMenu,
- Description: self.c.Tr.SwitchRepo,
+ Key: opts.GetKey(opts.Config.Status.RecentRepos),
+ Handler: self.c.Helpers().Repos.CreateRecentReposMenu,
+ Description: self.c.Tr.SwitchRepo,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Status.AllBranchesLogGraph),
diff --git a/pkg/gui/controllers/submodules_controller.go b/pkg/gui/controllers/submodules_controller.go
index 42177852c..3cf3b5bf5 100644
--- a/pkg/gui/controllers/submodules_controller.go
+++ b/pkg/gui/controllers/submodules_controller.go
@@ -46,6 +46,7 @@ func (self *SubmodulesController) GetKeybindings(opts types.KeybindingsOpts) []*
Description: self.c.Tr.Enter,
Tooltip: utils.ResolvePlaceholderString(self.c.Tr.EnterSubmoduleTooltip,
map[string]string{"escape": keybindings.Label(opts.Config.Universal.Return)}),
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Select),
@@ -58,6 +59,7 @@ func (self *SubmodulesController) GetKeybindings(opts types.KeybindingsOpts) []*
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Remove,
Tooltip: self.c.Tr.RemoveSubmoduleTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Submodules.Update),
@@ -65,11 +67,13 @@ func (self *SubmodulesController) GetKeybindings(opts types.KeybindingsOpts) []*
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Update,
Tooltip: self.c.Tr.SubmoduleUpdateTooltip,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.New),
- Handler: self.add,
- Description: self.c.Tr.NewSubmodule,
+ Key: opts.GetKey(opts.Config.Universal.New),
+ Handler: self.add,
+ Description: self.c.Tr.NewSubmodule,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Edit),
diff --git a/pkg/gui/controllers/tags_controller.go b/pkg/gui/controllers/tags_controller.go
index 3992b485e..3d7609f4b 100644
--- a/pkg/gui/controllers/tags_controller.go
+++ b/pkg/gui/controllers/tags_controller.go
@@ -39,12 +39,14 @@ func (self *TagsController) GetKeybindings(opts types.KeybindingsOpts) []*types.
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Checkout,
Tooltip: self.c.Tr.TagCheckoutTooltip,
+ DisplayOnScreen: true,
},
{
- Key: opts.GetKey(opts.Config.Universal.New),
- Handler: self.create,
- Description: self.c.Tr.NewTag,
- Tooltip: self.c.Tr.NewTagTooltip,
+ Key: opts.GetKey(opts.Config.Universal.New),
+ Handler: self.create,
+ Description: self.c.Tr.NewTag,
+ Tooltip: self.c.Tr.NewTagTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Remove),
@@ -53,6 +55,7 @@ func (self *TagsController) GetKeybindings(opts types.KeybindingsOpts) []*types.
GetDisabledReason: self.require(self.singleItemSelected()),
Tooltip: self.c.Tr.TagDeleteTooltip,
OpensMenu: true,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Branches.PushTag),
@@ -60,6 +63,7 @@ func (self *TagsController) GetKeybindings(opts types.KeybindingsOpts) []*types.
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.PushTag,
Tooltip: self.c.Tr.PushTagTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Commits.ViewResetOptions),
@@ -67,6 +71,7 @@ func (self *TagsController) GetKeybindings(opts types.KeybindingsOpts) []*types.
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Reset,
Tooltip: self.c.Tr.ResetTooltip,
+ DisplayOnScreen: true,
OpensMenu: true,
},
}
diff --git a/pkg/gui/controllers/worktrees_controller.go b/pkg/gui/controllers/worktrees_controller.go
index 3dd56a8ae..e9d15c02a 100644
--- a/pkg/gui/controllers/worktrees_controller.go
+++ b/pkg/gui/controllers/worktrees_controller.go
@@ -37,9 +37,10 @@ func NewWorktreesController(
func (self *WorktreesController) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
bindings := []*types.Binding{
{
- Key: opts.GetKey(opts.Config.Universal.New),
- Handler: self.add,
- Description: self.c.Tr.NewWorktree,
+ Key: opts.GetKey(opts.Config.Universal.New),
+ Handler: self.add,
+ Description: self.c.Tr.NewWorktree,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Select),
@@ -47,6 +48,7 @@ func (self *WorktreesController) GetKeybindings(opts types.KeybindingsOpts) []*t
GetDisabledReason: self.require(self.singleItemSelected()),
Description: self.c.Tr.Switch,
Tooltip: self.c.Tr.SwitchToWorktreeTooltip,
+ DisplayOnScreen: true,
},
{
Key: opts.GetKey(opts.Config.Universal.Confirm),
@@ -65,6 +67,7 @@ func (self *WorktreesController) GetKeybindings(opts types.KeybindingsOpts) []*t
GetDisabledReason: self.require(self.singleItemSelected()),