summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Palashevskii <20725046+Renerick@users.noreply.github.com>2021-06-08 11:01:19 +0400
committerJesse Duffield <jessedduffield@gmail.com>2021-07-27 21:30:08 +1000
commit0a63f701e5bc5d3d78b34dcb71f7343e520ae385 (patch)
treecafedbc644e572014cf35f872c1b07b28f3b264f
parentbccf203a18b9cc09bea66c21954daaff43fd1496 (diff)
Apply suggestions from code review
Co-authored-by: Mark Kopenga <mkopenga@gmail.com>
-rw-r--r--pkg/commands/pull_request.go8
-rw-r--r--pkg/i18n/dutch.go4
2 files changed, 5 insertions, 7 deletions
diff --git a/pkg/commands/pull_request.go b/pkg/commands/pull_request.go
index 9a29ae17a..40cabd0c7 100644
--- a/pkg/commands/pull_request.go
+++ b/pkg/commands/pull_request.go
@@ -155,11 +155,9 @@ func (pr *PullRequest) getPullRequestURL(from *models.Branch, to *models.Branch)
}
repoInfo := getRepoInfoFromURL(repoURL)
- var toBranchName string
- if to == nil {
- toBranchName = ""
- } else {
- toBranchName = to.Name
+ toBranchName := ""
+ if to != nil {
+ toBranchName = to.Name
}
pullRequestURL := gitService.PullRequestURL(repoInfo.Owner, repoInfo.Repository, from.Name, toBranchName)
diff --git a/pkg/i18n/dutch.go b/pkg/i18n/dutch.go
index e52a2ead5..fca78466e 100644
--- a/pkg/i18n/dutch.go
+++ b/pkg/i18n/dutch.go
@@ -396,7 +396,7 @@ func dutchTranslationSet() TranslationSet {
LcInitSubmodule: "initialiseer submodule",
LcViewBulkSubmoduleOptions: "bekijk bulk submodule opties",
LcViewStashFiles: "bekijk bestanden van stash entry",
- CreatePullRequestOptions: "Maak opties voor pull-aanvragen",
- LcCreatePullRequestOptions: "maak opties voor pull-aanvragen",
+ CreatePullRequestOptions: "Creëer pull request opties",
+ LcCreatePullRequestOptions: "creëer pull request opties",
}
}