summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Burke <rich.g.burke@gmail.com>2018-02-02 20:54:05 +0000
committerRichard Burke <rich.g.burke@gmail.com>2018-02-02 20:55:45 +0000
commit5d8a501907a9f10e8290eeb18b0e0db7c9a43bd2 (patch)
tree092006f35b2376fe2a9557dae50642f6483ca7d1
parenta30318d3dadd8a1fa3b454b4b8bed2282741f3d8 (diff)
Validate lineIndex in RenderHelpBar for the diff viewv0.1.1
Fixes #29
-rw-r--r--cmd/grv/diff_view.go15
1 files changed, 9 insertions, 6 deletions
diff --git a/cmd/grv/diff_view.go b/cmd/grv/diff_view.go
index 57be750..a9c0fd5 100644
--- a/cmd/grv/diff_view.go
+++ b/cmd/grv/diff_view.go
@@ -259,7 +259,7 @@ func (diffView *DiffView) renderEmptyView(win RenderWindow) (err error) {
return
}
-// RenderHelpBar does nothing
+// RenderHelpBar renders help information for the diff view
func (diffView *DiffView) RenderHelpBar(lineBuilder *LineBuilder) (err error) {
diffView.lock.Lock()
defer diffView.lock.Unlock()
@@ -274,12 +274,15 @@ func (diffView *DiffView) RenderHelpBar(lineBuilder *LineBuilder) (err error) {
}
lineIndex := diffView.viewPos.ActiveRowIndex()
- line := diffLines.lines[lineIndex]
- if line.lineType == dltDiffStatsFile {
- RenderKeyBindingHelp(diffView.ViewID(), lineBuilder, []ActionMessage{
- {action: ActionSelect, message: "Jump to file diff"},
- })
+ if lineIndex < uint(len(diffLines.lines)) {
+ line := diffLines.lines[lineIndex]
+
+ if line.lineType == dltDiffStatsFile {
+ RenderKeyBindingHelp(diffView.ViewID(), lineBuilder, []ActionMessage{
+ {action: ActionSelect, message: "Jump to file diff"},
+ })
+ }
}
return