summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Beyer <mail@beyermatthias.de>2021-12-28 19:09:31 +0100
committerMatthias Beyer <mail@beyermatthias.de>2021-12-28 19:09:32 +0100
commitf8331574d0034e08c6326513a58310b7dec153dd (patch)
tree364c0cf8ffd6d949508e3b37b6dccdf5ff37127a
parent1565ca6ccf4db827c2ab56417916d977c9c4959d (diff)
Add #[must_use] annotations
Clippy nightly fails the checks because it wants us to have a `#[must_use]` annotation on functions that return `Self`. So we add these annotations with this patch. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
-rw-r--r--src/builder.rs3
-rw-r--r--src/env.rs5
-rw-r--r--src/error.rs4
-rw-r--r--src/file/mod.rs2
4 files changed, 14 insertions, 0 deletions
diff --git a/src/builder.rs b/src/builder.rs
index 7a26151..f429ad4 100644
--- a/src/builder.rs
+++ b/src/builder.rs
@@ -181,6 +181,7 @@ impl ConfigBuilder<DefaultState> {
/// Registers new [`Source`] in this builder.
///
/// Calling this method does not invoke any I/O. [`Source`] is only saved in internal register for later use.
+ #[must_use]
pub fn add_source<T>(mut self, source: T) -> Self
where
T: Source + Send + Sync + 'static,
@@ -270,6 +271,7 @@ impl ConfigBuilder<AsyncState> {
/// Registers new [`Source`] in this builder.
///
/// Calling this method does not invoke any I/O. [`Source`] is only saved in internal register for later use.
+ #[must_use]
pub fn add_source<T>(mut self, source: T) -> ConfigBuilder<AsyncState>
where
T: Source + Send + Sync + 'static,
@@ -281,6 +283,7 @@ impl ConfigBuilder<AsyncState> {
/// Registers new [`AsyncSource`] in this builder.
///
/// Calling this method does not invoke any I/O. [`AsyncSource`] is only saved in internal register for later use.
+ #[must_use]
pub fn add_async_source<T>(mut self, source: T) -> ConfigBuilder<AsyncState>
where
T: AsyncSource + Send + Sync + 'static,
diff --git a/src/env.rs b/src/env.rs
index 854b9a8..065c36b 100644
--- a/src/env.rs
+++ b/src/env.rs
@@ -77,16 +77,19 @@ impl Environment {
}
}
+ #[must_use]
pub fn prefix(mut self, s: &str) -> Self {
self.prefix = Some(s.into());
self
}
+ #[must_use]
pub fn separator(mut self, s: &str) -> Self {
self.separator = Some(s.into());
self
}
+ #[must_use]
pub fn ignore_empty(mut self, ignore: bool) -> Self {
self.ignore_empty = ignore;
self
@@ -94,11 +97,13 @@ impl Environment {
/// Note: enabling `try_parsing` can reduce performance it will try and parse
/// each environment variable 3 times (bool, i64, f64)
+ #[must_use]
pub fn try_parsing(mut self, try_parsing: bool) -> Self {
self.try_parsing = try_parsing;
self
}
+ #[must_use]
pub fn source(mut self, source: Option<Map<String, String>>) -> Self {
self.source = source;
self
diff --git a/src/error.rs b/src/error.rs
index 84984ba..83ee416 100644
--- a/src/error.rs
+++ b/src/error.rs
@@ -114,6 +114,7 @@ impl ConfigError {
// FIXME: pub(crate)
#[doc(hidden)]
+ #[must_use]
pub fn extend_with_key(self, key: &str) -> Self {
match self {
ConfigError::Type {
@@ -132,6 +133,7 @@ impl ConfigError {
}
}
+ #[must_use]
fn prepend(self, segment: String, add_dot: bool) -> Self {
let concat = |key: Option<String>| {
let key = key.unwrap_or_else(String::new);
@@ -159,10 +161,12 @@ impl ConfigError {
}
}
+ #[must_use]
pub(crate) fn prepend_key(self, key: String) -> Self {
self.prepend(key, true)
}
+ #[must_use]
pub(crate) fn prepend_index(self, idx: usize) -> Self {
self.prepend(format!("[{}]", idx), false)
}
diff --git a/src/file/mod.rs b/src/file/mod.rs
index 629a866..007c250 100644
--- a/src/file/mod.rs
+++ b/src/file/mod.rs
@@ -101,11 +101,13 @@ where
F: FileStoredFormat + 'static,
T: FileSource<F>,
{
+ #[must_use]
pub fn format(mut self, format: F) -> Self {
self.format = Some(format);
self
}
+ #[must_use]
pub fn required(mut self, required: bool) -> Self {
self.required = required;
self