diff options
| author | har7an <99636919+har7an@users.noreply.github.com> | 2022-11-09 08:40:02 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-09 08:40:02 +0000 |
| commit | 5975af6e42f512700101b3ca4ad6cbe5ca416117 (patch) | |
| tree | e18eac6b0671c20a1d045d2e4c7b497280d9dc62 | |
| parent | 48bc2281c74732559c74c2d678895cdfeec08126 (diff) | |
cargo: Don't strip release binary (#1916)
* cargo: Don't strip release binary
because the lack of debug symbols makes the panic backtrace completely
useless. It will show a long list of unknown locations then.
Except for a minor space saving of 3-4 MB, debug symbols don't have any
negative side-effects for our application that we're aware of.
* changelog: Add PR #1916
Don't strip debug symbols from release binaries so the backtraces
contain the function names involved.
* cargo: Explicitly keep debug symbols
and add a comment explaining why.
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | Cargo.toml | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c7d7e243..43d7fd0d9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * debugging: Improve error logging in server (https://github.com/zellij-org/zellij/pull/1881) * docs: add kanagawa theme (https://github.com/zellij-org/zellij/pull/1913) * fix: use 'temp_dir' instead of hard-coded '/tmp/' (https://github.com/zellij-org/zellij/pull/1898) +* debugging: Don't strip debug symbols from release binaries (https://github.com/zellij-org/zellij/pull/1916) ## [0.32.0] - 2022-10-25 diff --git a/Cargo.toml b/Cargo.toml index fb16b35de..428657a52 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -45,7 +45,8 @@ members = [ [profile.release] lto = true -strip = true +# Keep debug symbols so we see function names in backtraces +strip = false [package.metadata.deb] depends = "$auto" |