From 88137396733896eb5e49c2b3b73d9a496d6ce49a Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Fri, 12 Nov 2021 16:01:15 +0000 Subject: patch 8.2.3585: crash when passing float to "term_rows" of term_start() Problem: Crash when passing float to "term_rows" in the options argument of term_start(). (Virginia Senioria) Solution: Bail out if the argument is not a number. (closes #9116) --- src/job.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/job.c') diff --git a/src/job.c b/src/job.c index fcb482c706..80cb47eeb1 100644 --- a/src/job.c +++ b/src/job.c @@ -424,10 +424,14 @@ get_job_options(typval_T *tv, jobopt_T *opt, int supported, int supported2) } else if (STRCMP(hi->hi_key, "term_rows") == 0) { + int error = FALSE; + if (!(supported2 & JO2_TERM_ROWS)) break; opt->jo_set2 |= JO2_TERM_ROWS; - opt->jo_term_rows = tv_get_number(item); + opt->jo_term_rows = tv_get_number_chk(item, &error); + if (error) + return FAIL; } else if (STRCMP(hi->hi_key, "term_cols") == 0) { -- cgit v1.2.3