From 1f5175d9af3d3f37e19f23e0e6f84caec47390f2 Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Sat, 13 Apr 2024 17:52:26 +0200 Subject: patch 9.1.0313: Crash when using heredoc with comment in command block Problem: Crash when using heredoc with comment in command block. Solution: Handle a newline more like the end of the line, fix coverity warning (zeertzjq). closes: #14535 Signed-off-by: zeertzjq Signed-off-by: Yegappan Lakshmanan Signed-off-by: Christian Brabandt --- src/evalvars.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'src/evalvars.c') diff --git a/src/evalvars.c b/src/evalvars.c index 62728ed8ab..d4dd0add2a 100644 --- a/src/evalvars.c +++ b/src/evalvars.c @@ -781,8 +781,15 @@ heredoc_get(exarg_T *eap, char_u *cmd, int script_get, int vim9compile) int count = 0; int heredoc_in_string = FALSE; char_u *line_arg = NULL; + char_u *nl_ptr = vim_strchr(cmd, '\n'); - if (eap->ea_getline == NULL && vim_strchr(cmd, '\n') == NULL) + if (nl_ptr != NULL) + { + heredoc_in_string = TRUE; + line_arg = nl_ptr + 1; + *nl_ptr = NUL; + } + else if (eap->ea_getline == NULL) { emsg(_(e_cannot_use_heredoc_here)); return NULL; @@ -826,14 +833,8 @@ heredoc_get(exarg_T *eap, char_u *cmd, int script_get, int vim9compile) if (*cmd != NUL && *cmd != comment_char) { marker = skipwhite(cmd); - p = skiptowhite_or_nl(marker); - if (*p == NL) - { - // heredoc in a string - line_arg = p + 1; - heredoc_in_string = TRUE; - } - else if (*skipwhite(p) != NUL && *skipwhite(p) != comment_char) + p = skiptowhite(marker); + if (*skipwhite(p) != NUL && *skipwhite(p) != comment_char) { semsg(_(e_trailing_characters_str), p); return NULL; -- cgit v1.2.3