From bc222152d8dea252aa5f1fa24b5536ed269feb92 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 23 Nov 2022 11:34:01 +0000 Subject: patch 9.0.0926: Coverity warns for not using return value of dict_add() Problem: Coverity warns for not using return value of dict_add(). Solution: When dict_add() fails then don't call hash_remove(). --- src/dict.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/dict.c') diff --git a/src/dict.c b/src/dict.c index 30264a9134..ffd5d381ec 100644 --- a/src/dict.c +++ b/src/dict.c @@ -1122,10 +1122,11 @@ dict_extend(dict_T *d1, dict_T *d2, char_u *action, char *func_name) { if (*action == 'm') { - // cheap way to move a dict item from "d2" to "d1" + // Cheap way to move a dict item from "d2" to "d1". + // If dict_add() fails then "d2" won't be empty. di1 = HI2DI(hi2); - dict_add(d1, di1); - hash_remove(&d2->dv_hashtab, hi2); + if (dict_add(d1, di1) == OK) + hash_remove(&d2->dv_hashtab, hi2); } else { -- cgit v1.2.3