From ef54a08080ef7d721d05361bf10e27217c87590e Mon Sep 17 00:00:00 2001
From: nicm <nicm>
Date: Wed, 18 Dec 2019 07:48:56 +0000
Subject: Do not rely on errno after glob(3) fails.

---
 cmd-source-file.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

(limited to 'cmd-source-file.c')

diff --git a/cmd-source-file.c b/cmd-source-file.c
index a07c27c7..6af1a6d0 100644
--- a/cmd-source-file.c
+++ b/cmd-source-file.c
@@ -130,7 +130,7 @@ cmd_source_file_exec(struct cmd *self, struct cmdq_item *item)
 	char				*pattern, *cwd;
 	const char			*path, *error;
 	glob_t				 g;
-	int				 i;
+	int				 i, result;
 	u_int				 j;
 
 	cdata = xcalloc(1, sizeof *cdata);
@@ -158,9 +158,15 @@ cmd_source_file_exec(struct cmd *self, struct cmdq_item *item)
 			xasprintf(&pattern, "%s/%s", cwd, path);
 		log_debug("%s: %s", __func__, pattern);
 
-		if (glob(pattern, 0, NULL, &g) != 0) {
-			error = strerror(errno);
-			if (errno != ENOENT || (~flags & CMD_PARSE_QUIET)) {
+		if ((result = glob(pattern, 0, NULL, &g)) != 0) {
+			if (result != GLOB_NOMATCH ||
+			    (~flags & CMD_PARSE_QUIET)) {
+				if (result == GLOB_NOMATCH)
+					error = strerror(ENOENT);
+				else if (result == GLOB_NOSPACE)
+					error = strerror(ENOMEM);
+				else
+					error = strerror(EINVAL);
 				cmdq_error(item, "%s: %s", path, error);
 				retval = CMD_RETURN_ERROR;
 			}
-- 
cgit v1.2.3