From 52847a951802fda7a3ce36cdac77c34914b0ccca Mon Sep 17 00:00:00 2001 From: nicm Date: Sun, 15 Jan 2017 22:00:56 +0000 Subject: It is silly for cmd_list_parse to return an integer error when it could just return NULL. --- cmd-confirm-before.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'cmd-confirm-before.c') diff --git a/cmd-confirm-before.c b/cmd-confirm-before.c index a2ffd059..e7366ec2 100644 --- a/cmd-confirm-before.c +++ b/cmd-confirm-before.c @@ -112,7 +112,8 @@ cmd_confirm_before_callback(void *data, const char *s, __unused int done) if (tolower((u_char) s[0]) != 'y' || s[1] != '\0') return (0); - if (cmd_string_parse(cdata->cmd, &cmdlist, NULL, 0, &cause) != 0) { + cmdlist = cmd_string_parse(cdata->cmd, NULL, 0, &cause); + if (cmdlist == NULL) { if (cause != NULL) { new_item = cmdq_get_callback(cmd_confirm_before_error, cause); -- cgit v1.2.3