Trying to set FD_CLOEXEC on every fd is a lost cause, just use

closefrom() before exec.

1 files changed, 2 insertions, 2 deletions

diff --git a/job.c b/job.c
index e0dc99ef..ef4066e5 100644
--- a/job.c
+++ b/job.c
@@ -169,6 +169,8 @@ job_run(struct job *job)
 		if (nullfd != STDIN_FILENO && nullfd != STDERR_FILENO)
 			close(nullfd);
 
+		closefrom(STDERR_FILENO + 1);
+
 		execl(_PATH_BSHELL, "sh", "-c", job->cmd, (char *) NULL);
 		fatal("execl failed");
 	default:	/* parent */
@@ -179,8 +181,6 @@ job_run(struct job *job)
 			fatal("fcntl failed");
 		if (fcntl(job->fd, F_SETFL, mode|O_NONBLOCK) == -1)
 			fatal("fcntl failed");
-		if (fcntl(job->fd, F_SETFD, FD_CLOEXEC) == -1)
-			fatal("fcntl failed");
 
 		if (job->event != NULL)
 			bufferevent_free(job->event);