1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
|
use crate::error::*;
use crate::size_threshold::SizeThreshold;
use crate::{converter::*, operations::Operations};
use c8y_smartrest::smartrest_serializer::{SmartRestSerializer, SmartRestSetSupportedOperations};
use c8y_translator::json;
use mqtt_client::{Message, Topic};
use std::collections::HashSet;
const SMARTREST_PUBLISH_TOPIC: &str = "c8y/s/us";
pub struct CumulocityConverter {
pub(crate) size_threshold: SizeThreshold,
children: HashSet<String>,
pub(crate) mapper_config: MapperConfig,
}
impl CumulocityConverter {
pub fn new(size_threshold: SizeThreshold) -> Self {
let mut topic_fiter = make_valid_topic_filter_or_panic("tedge/measurements");
let () = topic_fiter
.add("tedge/measurements/+")
.expect("invalid topic filter");
let mapper_config = MapperConfig {
in_topic_filter: topic_fiter,
out_topic: make_valid_topic_or_panic("c8y/measurement/measurements/create"),
errors_topic: make_valid_topic_or_panic("tedge/errors"),
};
let children: HashSet<String> = HashSet::new();
CumulocityConverter {
size_threshold,
children,
mapper_config,
}
}
}
impl Converter for CumulocityConverter {
type Error = ConversionError;
fn get_mapper_config(&self) -> &MapperConfig {
&self.mapper_config
}
fn try_convert(&mut self, input: &Message) -> Result<Vec<Message>, ConversionError> {
let () = self.size_threshold.validate(input.payload_str()?)?;
let mut vec: Vec<Message> = Vec::new();
let maybe_child_id = get_child_id_from_topic(&input.topic.name)?;
match maybe_child_id {
Some(child_id) => {
// Need to check if the input Thin Edge JSON is valid before adding a child ID to list
let c8y_json_child_payload =
json::from_thin_edge_json_with_child(input.payload_str()?, child_id.as_str())?;
if !self.children.contains(child_id.as_str()) {
self.children.insert(child_id.clone());
vec.push(Message::new(
&Topic::new_unchecked(SMARTREST_PUBLISH_TOPIC),
format!("101,{},{},thin-edge.io-child", child_id, child_id),
));
}
vec.push(Message::new(
&self.mapper_config.out_topic,
c8y_json_child_payload,
));
}
None => {
let c8y_json_payload = json::from_thin_edge_json(input.payload_str()?)?;
vec.push(Message::new(
&self.mapper_config.out_topic,
c8y_json_payload,
));
}
}
Ok(vec)
}
fn try_init_messages(&self) -> Result<Vec<Message>, ConversionError> {
let ops = Operations::try_new("/etc/tedge/operations")?;
let ops = ops.get_operations_list("c8y");
if !ops.is_empty() {
let ops_msg = SmartRestSetSupportedOperations::new(&ops);
let topic = Topic::new_unchecked("c8y/s/us");
let msg = Message::new(&topic, ops_msg.to_smartrest()?);
Ok(vec![msg])
} else {
Ok(Vec::new())
}
}
}
fn get_child_id_from_topic(topic: &str) -> Result<Option<String>, ConversionError> {
match topic.strip_prefix("tedge/measurements/").map(String::from) {
Some(maybe_id) if maybe_id.is_empty() => {
Err(ConversionError::InvalidChildId { id: maybe_id })
}
option => Ok(option),
}
}
#[cfg(test)]
mod test {
use super::*;
use test_case::test_case;
#[test_case("tedge/measurements/test", Some("test".to_string()); "valid child id")]
#[test_case("tedge/measurements/", None; "returns an error (empty value)")]
#[test_case("tedge/measurements", None; "invalid child id (parent topic)")]
#[test_case("foo/bar", None; "invalid child id (invalid topic)")]
fn extract_child_id(in_topic: &str, expected_child_id: Option<String>) {
match get_child_id_from_topic(in_topic) {
Ok(maybe_id) => assert_eq!(maybe_id, expected_child_id),
Err(ConversionError::InvalidChildId { id }) => {
assert_eq!(id, "".to_string())
}
_ => {
panic!("Unexpected error type")
}
}
}
#[test]
fn convert_thin_edge_json_with_child_id() {
let mut converter = Box::new(CumulocityConverter::new(SizeThreshold(16 * 1024)));
let in_topic = "tedge/measurements/child1";
let in_payload = r#"{"temp": 1, "time": "2021-11-16T17:45:40.571760714+01:00"}"#;
let in_message = Message::new(&Topic::new_unchecked(in_topic), in_payload);
let expected_smart_rest_message = Message::new(
&Topic::new_unchecked("c8y/s/us"),
"101,child1,child1,thin-edge.io-child",
);
let expected_c8y_json_message = Message::new(
&Topic::new_unchecked("c8y/measurement/measurements/create"),
r#"{"type":"ThinEdgeMeasurement","externalSource":{"externalId":"child1","type":"c8y_Serial"},"temp":{"temp":{"value":1.0}},"time":"2021-11-16T17:45:40.571760714+01:00"}"#,
);
// Test the first output messages contains SmartREST and C8Y JSON.
let out_first_messages = converter.convert(&in_message);
assert_eq!(
out_first_messages,
vec![
expected_smart_rest_message,
expected_c8y_json_message.clone()
]
);
// Test the second output messages doesn't contain SmartREST child device creation.
let out_second_messages = converter.convert(&in_message);
assert_eq!(out_second_messages, vec![expected_c8y_json_message.clone()]);
}
#[test]
fn convert_first_thin_edge_json_invalid_then_valid_with_child_id() {
let mut converter = Box::new(CumulocityConverter::new(SizeThreshold(16 * 1024)));
let in_topic = "tedge/measurements/child1";
let in_invalid_payload = r#"{"temp": invalid}"#;
let in_valid_payload = r#"{"temp": 1, "time": "2021-11-16T17:45:40.571760714+01:00"}"#;
let in_first_message = Message::new(&Topic::new_unchecked(in_topic), in_invalid_payload);
let in_second_message = Message::new(&Topic::new_unchecked(in_topic), in_valid_payload);
// First convert invalid Thin Edge JSON message.
let out_first_messages = converter.convert(&in_first_message);
let expected_error_message = Message::new(
&Topic::new_unchecked("tedge/errors"),
r#"Invalid JSON: expected value at line 1 column 10: `invalid}`"#,
);
assert_eq!(out_first_messages, vec![expected_error_message]);
// Second convert valid Thin Edge JSON message.
let out_second_messages = converter.convert(&in_second_message);
let expected_smart_rest_message = Message::new(
&Topic::new_unchecked("c8y/s/us"),
"101,child1,child1,thin-edge.io-child",
);
let expected_c8y_json_message = Message::new(
&Topic::new_unchecked("c8y/measurement/measurements/create"),
r#"{"type":"ThinEdgeMeasurement","externalSource":{"externalId":"child1","type":"c8y_Serial"},"temp":{"temp":{"value":1.0}},"time":"2021-11-16T17:45:40.571760714+01:00"}"#,
);
assert_eq!(
out_second_messages,
vec![
expected_smart_rest_message,
expected_c8y_json_message.clone()
]
);
}
#[test]
fn convert_two_thin_edge_json_messages_given_different_child_id() {
let mut converter = Box::new(CumulocityConverter::new(SizeThreshold(16 * 1024)));
let in_payload = r#"{"temp": 1, "time": "2021-11-16T17:45:40.571760714+01:00"}"#;
// First message from "child1"
let in_first_message = Message::new(
&Topic::new_unchecked("tedge/measurements/child1"),
in_payload,
);
let out_first_messages = converter.convert(&in_first_message);
let expected_first_smart_rest_message = Message::new(
&Topic::new_unchecked("c8y/s/us"),
"101,child1,child1,thin-edge.io-child",
);
let expected_first_c8y_json_message = Message::new(
&Topic::new_unchecked("c8y/measurement/measurements/create"),
r#"{"type":"ThinEdgeMeasurement","externalSource":{"externalId":"child1","type":"c8y_Serial"},"temp":{"temp":{"value":1.0}},"time":"2021-11-16T17:45:40.571760714+01:00"}"#,
);
assert_eq!(
out_first_messages,
vec![
expected_first_smart_rest_message,
expected_first_c8y_json_message
]
);
// Second message from "ch
|