From 1dec0d32c08b43f846cfb9c3fdf2817ddc7d0288 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Wed, 31 Aug 2022 11:08:52 +0200 Subject: Move section on signed-off-by trailer In de3bcc7e16b69d753b132ebbbb4da8073cf18b74 ("Move "Repository maintenance" section to CONTRIBUTING.md") we moved the "Repository maintenance" section to the CONTRIBUTING.md file. This patch moves the section on the signed-off-by trailer from the "Repository maintenance" section.. Fixes: de3bcc7e16b69d753b132ebbbb4da8073cf18b74 ("Move "Repository maintenance" section to CONTRIBUTING.md") Signed-off-by: Matthias Beyer --- CONTRIBUTING.md | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index faf90829..62c9a9ca 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -85,6 +85,19 @@ You can also read about commit messages in Commits using the `--fixup` or `--squash` feature of `git-commit` are allowed, but will have to be squashed by the pull request author before being merged. +### Ensuring the Signed-off-by-trailer + +Contributors need to sign the "Contributor License Agreement". They do so by +signing off each individual commit with a so-called "Signed-off-by Trailer". +Git offers the `--signoff`/`-s` flags when using `git-commit` to commit +changes. + +To ensure that all commits have the trailer present in the commit message, a +CI lint is installed in the github actions workflows of the project. This lint +blocks pull requests from being merged if one or more of the commits of the pull +request misses the `Signed-off-by` trailer. + +As a result, it is not possible to merge pull requests that miss the trailer. ## Reviewing, addressing feedback, and merging @@ -191,18 +204,6 @@ See [setting your commit email address in Git](https://docs.github.com/en/github ## Repository maintenance -- **Ensuring the Signed-off-by-trailer** - Contributors need to sign the "Contributor License Agreement". They do so by - signing off each individual commit with a so-called "Signed-off-by Trailer". - Git offers the `--signoff`/`-s` flags when using `git-commit` to commit - changes. - - To ensure that all commits have the trailer present in the commit message, a - CI lint is installed in the github actions workflows of the project. This lint - blocks pull requests to be merged if one or more of the commits of the pull - request misses the `Signed-off-by` trailer. - - As a result, it is not possible to merge pull requests that miss the trailer. - **Coding styleguide** Coding style is enforced via `rustfmt` in its default configuration. Compliance with the coding style is enforced via CI. -- cgit v1.2.3