diff options
| author | Matthias Beyer <matthias.beyer@ifm.com> | 2022-02-11 08:47:01 +0100 |
|---|---|---|
| committer | Matthias Beyer <matthias.beyer@ifm.com> | 2022-02-22 08:32:59 +0100 |
| commit | ebc3b95d458bb920dbb72ae53d0b9e7c9259ad34 (patch) | |
| tree | db1a87992f3977d75e97e96a2164effdb1df328a /CONTRIBUTING.md | |
| parent | 84b28f32de35b7d3b7b42fe07b7f97ceba6a2857 (diff) | |
Fix: We only need one approval right now
Signed-off-by: Matthias Beyer <matthias.beyer@ifm.com>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d107169c..53426f81 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,7 +33,7 @@ Git commit messages should explain the how and why of your change and be separat ## Reviewing, addressing feedback, and merging -Generally, pull requests need two approvals from maintainers to be merged. +Generally, pull requests need at least an approval from one maintainer to be merged. When addressing review feedback, it is helpful to the reviewer if additional changes are made in new commits. This allows the reviewer to easily see the delta between what they previously reviewed and the changes you added to address their feedback. |