diff options
author | Matthias Beyer <matthias.beyer@ifm.com> | 2022-07-22 08:23:40 +0200 |
---|---|---|
committer | Matthias Beyer <matthias.beyer@ifm.com> | 2022-08-18 14:46:54 +0200 |
commit | 2d293a6ff0dedce3f7c663566fe018dd5c52433b (patch) | |
tree | 983ccbde7a1b1430bdf9292e319e099344928c74 | |
parent | 461530a53b15afb23b3c4a0d1606cc136f601da2 (diff) |
Fix clippy in tedge: Remove let-unit-value
This patch fixes `clippy::let_unit_value`.
Signed-off-by: Matthias Beyer <matthias.beyer@ifm.com>
8 files changed, 13 insertions, 16 deletions
diff --git a/crates/core/tedge/src/cli/certificate/create.rs b/crates/core/tedge/src/cli/certificate/create.rs index 2d1589c9..83eeb45f 100644 --- a/crates/core/tedge/src/cli/certificate/create.rs +++ b/crates/core/tedge/src/cli/certificate/create.rs @@ -28,7 +28,7 @@ impl Command for CreateCertCmd { fn execute(&self) -> anyhow::Result<()> { let config = NewCertificateConfig::default(); - let () = self.create_test_certificate(&config)?; + self.create_test_certificate(&config)?; Ok(()) } } diff --git a/crates/core/tedge/src/cli/certificate/remove.rs b/crates/core/tedge/src/cli/certificate/remove.rs index 8f978972..c1007b44 100644 --- a/crates/core/tedge/src/cli/certificate/remove.rs +++ b/crates/core/tedge/src/cli/certificate/remove.rs @@ -18,7 +18,7 @@ impl Command for RemoveCertCmd { } fn execute(&self) -> anyhow::Result<()> { - let () = self.remove_certificate()?; + self.remove_certificate()?; Ok(()) } } diff --git a/crates/core/tedge/src/cli/certificate/show.rs b/crates/core/tedge/src/cli/certificate/show.rs index 8890f308..24bc493d 100644 --- a/crates/core/tedge/src/cli/certificate/show.rs +++ b/crates/core/tedge/src/cli/certificate/show.rs @@ -16,7 +16,7 @@ impl Command for ShowCertCmd { } fn execute(&self) -> anyhow::Result<()> { - let () = self.show_certificate()?; + self.show_certificate()?; Ok(()) } } diff --git a/crates/core/tedge/src/cli/config/commands/set.rs b/crates/core/tedge/src/cli/config/commands/set.rs index 715f2664..ce2493a6 100644 --- a/crates/core/tedge/src/cli/config/commands/set.rs +++ b/crates/core/tedge/src/cli/config/commands/set.rs @@ -18,7 +18,7 @@ impl Command for SetConfigCommand { fn execute(&self) -> anyhow::Result<()> { let mut config = self.config_repository.load()?; - let () = (self.config_key.set)(&mut config, self.value.to_string())?; + (self.config_key.set)(&mut config, self.value.to_string())?; self.config_repository.store(&config)?; Ok(()) } diff --git a/crates/core/tedge/src/cli/config/commands/unset.rs b/crates/core/tedge/src/cli/config/commands/unset.rs index 222d8a3e..a975a58d 100644 --- a/crates/core/tedge/src/cli/config/commands/unset.rs +++ b/crates/core/tedge/src/cli/config/commands/unset.rs @@ -17,7 +17,7 @@ impl Command for UnsetConfigCommand { fn execute(&self) -> anyhow::Result<()> { let mut config = self.config_repository.load()?; - let () = (self.config_key.unset)(&mut config)?; + (self.config_key.unset)(&mut config)?; self.config_repository.store(&config)?; Ok(()) } diff --git a/crates/core/tedge/src/cli/connect/c8y_direct_connection.rs b/crates/core/tedge/src/cli/connect/c8y_direct_connection.rs index 89400667..1683b4d8 100644 --- a/crates/core/tedge/src/cli/connect/c8y_direct_connection.rs +++ b/crates/core/tedge/src/cli/connect/c8y_direct_connection.rs @@ -29,7 +29,7 @@ pub fn create_device_with_direct_connection( let mut client_config = ClientConfig::new(); - let () = load_root_certs( + load_root_certs( &mut client_config.root_store, bridge_config.bridge_root_cert_path.clone(), )?; diff --git a/crates/core/tedge/src/cli/connect/command.rs b/crates/core/tedge/src/cli/connect/command.rs index 8714bdd7..c525eb1d 100644 --- a/crates/core/tedge/src/cli/connect/command.rs +++ b/crates/core/tedge/src/cli/connect/command.rs @@ -242,7 +242,7 @@ where TEdgeConfig: ConfigSettingAccessor<T>, { let value = config.query(setting)?; - let () = config.update(setting, value)?; + config.update(setting, value)?; Ok(()) } @@ -402,17 +402,14 @@ fn new_bridge( } println!("Checking if configuration for requested bridge already exists.\n"); - let () = bridge_config_exists(config_location, bridge_config)?; + bridge_config_exists(config_location, bridge_config)?; println!("Validating the bridge certificates.\n"); - let () = bridge_config.validate()?; + bridge_config.validate()?; if bridge_config.cloud_name.eq("c8y") { println!("Creating the device in Cumulocity cloud.\n"); - let () = c8y_direct_connection::create_device_with_direct_connection( - bridge_config, - device_type, - )?; + c8y_direct_connection::create_device_with_direct_connection(bridge_config, device_type)?; } println!("Saving configuration for requested bridge.\n"); @@ -522,12 +519,12 @@ fn write_bridge_config_to_file( get_common_mosquitto_config_file_path(config_location, common_mosquitto_config); let mut common_draft = DraftFile::new(&common_config_path)?; common_mosquitto_config.serialize(&mut common_draft)?; - let () = common_draft.persist()?; + common_draft.persist()?; let config_path = get_bridge_config_file_path(config_location, bridge_config); let mut config_draft = DraftFile::new(config_path)?; bridge_config.serialize(&mut config_draft)?; - let () = config_draft.persist()?; + config_draft.persist()?; Ok(()) } diff --git a/crates/core/tedge/src/system_services/manager.rs b/crates/core/tedge/src/system_services/manager.rs index 83b4cd56..08caf6d9 100644 --- a/crates/core/tedge/src/system_services/manager.rs +++ b/crates/core/tedge/src/system_services/manager.rs @@ -33,7 +33,7 @@ pub trait SystemServiceManager: Debug { service: SystemService, ) -> Result<bool, SystemServiceError> { if self.is_service_running(service)? { - let () = self.restart_service(service)?; + self.restart_service(service)?; Ok(true) } else { Ok(false) |