summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Beyer <matthias.beyer@ifm.com>2022-02-07 09:25:24 +0100
committerMatthias Beyer <matthias.beyer@ifm.com>2022-02-07 10:12:02 +0100
commitf6f791dc581a7763719fbd3db42c3bfa4dce2b32 (patch)
treed50b4d07f5d60b5666c63405f9380de0821679a5
parentc15cfc4bee97473411ed173903f808c1132b8d8c (diff)
Replace new() constructor with Default impl
This fixes clippy lint `clippy::new_without_default`. Signed-off-by: Matthias Beyer <matthias.beyer@ifm.com>
-rw-r--r--crates/core/agent_interface/src/lib.rs4
-rw-r--r--crates/core/agent_interface/src/messages.rs6
-rw-r--r--crates/core/tedge_mapper/src/sm_c8y_mapper/mapper.rs2
3 files changed, 7 insertions, 5 deletions
diff --git a/crates/core/agent_interface/src/lib.rs b/crates/core/agent_interface/src/lib.rs
index 2fdcbd9e..147b2e88 100644
--- a/crates/core/agent_interface/src/lib.rs
+++ b/crates/core/agent_interface/src/lib.rs
@@ -50,7 +50,7 @@ mod tests {
#[test]
fn creating_a_software_list_request_with_generated_id() {
- let request = SoftwareListRequest::new();
+ let request = SoftwareListRequest::default();
let generated_id = request.id;
// The generated id is a nanoid of 21 characters from A-Za-z0-9_~
@@ -470,7 +470,7 @@ mod tests {
#[test]
fn creating_a_software_update_request_with_generated_id() {
- let request = SoftwareUpdateRequest::new();
+ let request = SoftwareUpdateRequest::default();
let generated_id = request.id;
// The generated id is a nanoid of 21 characters from A-Za-z0-9_~
diff --git a/crates/core/agent_interface/src/messages.rs b/crates/core/agent_interface/src/messages.rs
index 65c52d13..9b284697 100644
--- a/crates/core/agent_interface/src/messages.rs
+++ b/crates/core/agent_interface/src/messages.rs
@@ -43,12 +43,14 @@ pub struct SoftwareListRequest {
impl<'a> Jsonify<'a> for SoftwareListRequest {}
-impl SoftwareListRequest {
- pub fn new() -> SoftwareListRequest {
+impl Default for SoftwareListRequest {
+ fn default() -> SoftwareListRequest {
let id = nanoid!();
SoftwareListRequest { id }
}
+}
+impl SoftwareListRequest {
pub fn new_with_id(id: &str) -> SoftwareListRequest {
SoftwareListRequest { id: id.to_string() }
}
diff --git a/crates/core/tedge_mapper/src/sm_c8y_mapper/mapper.rs b/crates/core/tedge_mapper/src/sm_c8y_mapper/mapper.rs
index 88077a09..ce8ff5bd 100644
--- a/crates/core/tedge_mapper/src/sm_c8y_mapper/mapper.rs
+++ b/crates/core/tedge_mapper/src/sm_c8y_mapper/mapper.rs
@@ -230,7 +230,7 @@ where
#[instrument(skip(self), name = "software-list")]
async fn ask_software_list(&mut self) -> Result<(), SMCumulocityMapperError> {
- let request = SoftwareListRequest::new();
+ let request = SoftwareListRequest::default();
let topic = Topic::new(RequestTopic::SoftwareListRequest.as_str())?;
let json_list_request = request.to_json()?;
let () = self.publish(&topic, json_list_request).await?;