summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakob Borg <jakob@kastelo.net>2022-10-02 08:50:27 +0200
committerGitHub <noreply@github.com>2022-10-02 08:50:27 +0200
commita206366d103d18b80a81427660deaafff35e5550 (patch)
tree56f715eaad0a0d067fe341f0d5cac0e8eae215a3
parent1e652de5af96ccec4a6b384933e50717d49c8e64 (diff)
docker: Fix handling of PCAP variable (fixes #8567) (#8568)
This correctly handles the absense of the PCAP environment variable, which was broken in the previous change.
-rw-r--r--Dockerfile2
-rwxr-xr-xscript/docker-entrypoint.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/Dockerfile b/Dockerfile
index 7c4913be67..d201c0811c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -20,7 +20,7 @@ RUN apk add --no-cache ca-certificates su-exec tzdata libcap
COPY --from=builder /src/syncthing /bin/syncthing
COPY --from=builder /src/script/docker-entrypoint.sh /bin/entrypoint.sh
-ENV PUID=1000 PGID=1000 HOME=/var/syncthing PCAP=
+ENV PUID=1000 PGID=1000 HOME=/var/syncthing
HEALTHCHECK --interval=1m --timeout=10s \
CMD nc -z 127.0.0.1 8384 || exit 1
diff --git a/script/docker-entrypoint.sh b/script/docker-entrypoint.sh
index f56817d1b5..e93e56306b 100755
--- a/script/docker-entrypoint.sh
+++ b/script/docker-entrypoint.sh
@@ -4,7 +4,7 @@ set -eu
if [ "$(id -u)" = '0' ]; then
binary="$1"
- if [ "$PCAP" == "" ] ; then
+ if [ "${PCAP:-}" == "" ] ; then
# If Syncthing should have no extra capabilities, make sure to remove them
# from the binary. This will fail with an error if there are no
# capabilities to remove, hence the || true etc.