From c9249dbe0b8e508b0067512e1accdf80e4d014ec Mon Sep 17 00:00:00 2001 From: Chrissy LeMaire Date: Tue, 13 Jul 2021 22:31:14 +0200 Subject: fix(pwsh): replace Get-Error with $error[0] (#2873) Get-Error does not exist in all versions of PowerShell, and attempting to use it on machines where it does not exist pollutes $error. Someone may be tempted to use -ErrorAction Ignore but since the command does not exist, it still ends up in $error This is a dual bug fix because it actually gets errors on all machines now and it does not pollute $error. --- src/init/starship.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/init') diff --git a/src/init/starship.ps1 b/src/init/starship.ps1 index e5a1fb148..e5e36a54d 100644 --- a/src/init/starship.ps1 +++ b/src/init/starship.ps1 @@ -81,8 +81,8 @@ function global:prompt { if ($lastCmd = Get-History -Count 1) { # In case we have a False on the Dollar hook, we know there's an error. if (-not $origDollarQuestion) { - # We retrieve the InvocationInfo from the most recent error. - $lastCmdletError = try { Get-Error | Where-Object { $_ -ne $null } | Select-Object -expand InvocationInfo } catch { $null } + # We retrieve the InvocationInfo from the most recent error using $error[0] + $lastCmdletError = try { $error[0] | Where-Object { $_ -ne $null } | Select-Object -ExpandProperty InvocationInfo } catch { $null } # We check if the last command executed matches the line that caused the last error, in which case we know # it was an internal Powershell command, otherwise, there MUST be an error code. $lastExitCodeForPrompt = if ($null -ne $lastCmdletError -and $lastCmd.CommandLine -eq $lastCmdletError.Line) { 1 } else { $origLastExitCode } -- cgit v1.2.3