diff options
| author | Vidar Holen <spam@vidarholen.net> | 2018-09-03 12:33:32 -0700 |
|---|---|---|
| committer | Vidar Holen <spam@vidarholen.net> | 2018-09-03 12:36:25 -0700 |
| commit | f0a2e688c45a615f647b3a9ceffcd7ac35a0e882 (patch) | |
| tree | 7ebbf2aeee0c356845a4e5d6b8b618c04c5b8b65 | |
| parent | 0cee8a993d068c59c6a52d8ffd365fb60bda37d4 (diff) | |
Don't warn about LINENO since it's now POSIX. Fixes #644
| -rw-r--r-- | src/ShellCheck/Checks/ShellSupport.hs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/ShellCheck/Checks/ShellSupport.hs b/src/ShellCheck/Checks/ShellSupport.hs index 34133e0..1bc425f 100644 --- a/src/ShellCheck/Checks/ShellSupport.hs +++ b/src/ShellCheck/Checks/ShellSupport.hs @@ -127,7 +127,7 @@ prop_checkBashisms44= verifyNot checkBashisms "#!/bin/dash\ntrap foo int" prop_checkBashisms45= verifyNot checkBashisms "#!/bin/dash\ntrap foo INT" prop_checkBashisms46= verify checkBashisms "#!/bin/dash\ntrap foo SIGINT" prop_checkBashisms47= verify checkBashisms "#!/bin/dash\necho foo 42>/dev/null" -prop_checkBashisms48= verifyNot checkBashisms "#!/bin/dash\necho $LINENO" +prop_checkBashisms48= verifyNot checkBashisms "#!/bin/sh\necho $LINENO" prop_checkBashisms49= verify checkBashisms "#!/bin/dash\necho $MACHTYPE" prop_checkBashisms50= verify checkBashisms "#!/bin/sh\ncmd >& file" prop_checkBashisms51= verifyNot checkBashisms "#!/bin/sh\ncmd 2>&1" @@ -302,11 +302,11 @@ checkBashisms = ForShell [Sh, Dash] $ \t -> do (re $ "^[" ++ varChars ++ "*@]+(\\[.*\\])?/", "string replacement is") ] bashVars = [ - "LINENO", "OSTYPE", "MACHTYPE", "HOSTTYPE", "HOSTNAME", + "OSTYPE", "MACHTYPE", "HOSTTYPE", "HOSTNAME", "DIRSTACK", "EUID", "UID", "SHLVL", "PIPESTATUS", "SHELLOPTS" ] bashDynamicVars = [ "RANDOM", "SECONDS" ] - dashVars = [ "LINENO" ] + dashVars = [ ] isBashVariable var = (var `elem` bashDynamicVars || var `elem` bashVars && not (isAssigned var)) |