From 271fa11b31706b83509b21a4231015cb660ba8f1 Mon Sep 17 00:00:00 2001
From: Lars Wirzenius <liw@liw.fi>
Date: Tue, 28 Sep 2021 10:29:08 +0300
Subject: Allow new() without default()

It is customary in Rust to implement the Default trait for types that
can have a new method that takes no arguments. However, that's not
always wanted.

I've marked all the structures that have a new without arguments but
don't implement Default, so that if we get more of them, clippy will
warn.

Found by clippy lint new_without_default:
https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
---
 openpgp/src/cert/builder.rs | 1 +
 openpgp/src/cert/revoke.rs  | 4 ++++
 openpgp/src/packet/seip.rs  | 1 +
 3 files changed, 6 insertions(+)

(limited to 'openpgp')

diff --git a/openpgp/src/cert/builder.rs b/openpgp/src/cert/builder.rs
index 235f2cd9..c9f926a2 100644
--- a/openpgp/src/cert/builder.rs
+++ b/openpgp/src/cert/builder.rs
@@ -235,6 +235,7 @@ pub struct CertBuilder<'a> {
 }
 assert_send_and_sync!(CertBuilder<'_>);
 
+#[allow(clippy::new_without_default)]
 impl CertBuilder<'_> {
     /// Returns a new `CertBuilder`.
     ///
diff --git a/openpgp/src/cert/revoke.rs b/openpgp/src/cert/revoke.rs
index c3b02077..7ecb5787 100644
--- a/openpgp/src/cert/revoke.rs
+++ b/openpgp/src/cert/revoke.rs
@@ -83,6 +83,7 @@ pub struct CertRevocationBuilder {
 }
 assert_send_and_sync!(CertRevocationBuilder);
 
+#[allow(clippy::new_without_default)]
 impl CertRevocationBuilder {
     /// Returns a new `CertRevocationBuilder`.
     ///
@@ -333,6 +334,7 @@ pub struct SubkeyRevocationBuilder {
 }
 assert_send_and_sync!(SubkeyRevocationBuilder);
 
+#[allow(clippy::new_without_default)]
 impl SubkeyRevocationBuilder {
     /// Returns a new `SubkeyRevocationBuilder`.
     ///
@@ -579,6 +581,7 @@ pub struct UserIDRevocationBuilder {
 }
 assert_send_and_sync!(UserIDRevocationBuilder);
 
+#[allow(clippy::new_without_default)]
 impl UserIDRevocationBuilder {
     /// Returns a new `UserIDRevocationBuilder`.
     ///
@@ -839,6 +842,7 @@ pub struct UserAttributeRevocationBuilder {
 }
 assert_send_and_sync!(UserAttributeRevocationBuilder);
 
+#[allow(clippy::new_without_default)]
 impl UserAttributeRevocationBuilder {
     /// Returns a new `UserAttributeRevocationBuilder`.
     ///
diff --git a/openpgp/src/packet/seip.rs b/openpgp/src/packet/seip.rs
index e79bb2bb..b808acf2 100644
--- a/openpgp/src/packet/seip.rs
+++ b/openpgp/src/packet/seip.rs
@@ -46,6 +46,7 @@ impl std::ops::DerefMut for SEIP1 {
     }
 }
 
+#[allow(clippy::new_without_default)]
 impl SEIP1 {
     /// Creates a new SEIP1 packet.
     pub fn new() -> Self {
-- 
cgit v1.2.3