From 7febc9e2722f7ca97be91dc4a68c9f6a0502dc27 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Mon, 20 Sep 2021 19:26:48 +0300 Subject: Avoid matching on &Foo, when a plain Foo pattern works The extra & in a pattern (match arm or if let) is unnecessary and only makes the code harder to read. In most places it's enough to just remove the & from the pattern, but in a few places a dereference (*) needs to be added where the value captured in the pattern is used, as removing the & changes the type of the captured value to be a reference. Overall, the changes are almost mechanical. Although the diff is huge, it should be easy to read. The clippy lint match_ref_pats warns about this. See: https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats --- openpgp/src/message/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'openpgp/src/message/mod.rs') diff --git a/openpgp/src/message/mod.rs b/openpgp/src/message/mod.rs index 2d92f44d..662e4e02 100644 --- a/openpgp/src/message/mod.rs +++ b/openpgp/src/message/mod.rs @@ -408,7 +408,7 @@ impl Message { /// ``` pub fn body(&self) -> Option<&Literal> { for packet in self.pile.descendants() { - if let &Packet::Literal(ref l) = packet { + if let Packet::Literal(ref l) = packet { return Some(l); } } -- cgit v1.2.3