summaryrefslogtreecommitdiffstats
path: root/openpgp-ffi/src
AgeCommit message (Collapse)Author
2020-04-03openpgp: Convert `CertParser::from_packet_parser` to `From<PacketParserResult>`Wiktor Kwapisiewicz
2020-04-03openpgp: Convert Cert::from_packet_parser into TryFrom<PacketParserResult>Wiktor Kwapisiewicz
2020-04-03openpgp: Unify Message and writer::Stack, hide writers.Justus Winter
- Previously, Message::new returned a writer::Stack, and Message was just an empty struct. Unify the types. This makes sense, because if you have a message, and encrypt it, you get a message. - Make the writer module private. This is an implementation detail.
2020-04-03openpgp: Move key_amalgamation.rs to amalgamation/key.rs.Neal H. Walfield
2020-04-03openpgp: Rename KeyIter to KeyAmalgamationIterNeal H. Walfield
- Rename `KeyIter` to `KeyAmalgamationIter`, `ValidKeyIter` to `ValidKeyAmalgamationIter`. - Rename `cert/keyiter.rs` to `cert/amalgamation/iter.rs`.
2020-04-03openpgp: Rename ComponentIter to ComponentBundleIterNeal H. Walfield
- Rename `ComponentIter` to `ComponentBundleIter`, which is more accurate. - Rename the module from `cert/component_iter.rs` to `cert/bundle/iter.rs`.
2020-04-02openpgp-ffi: Use UserIDAmalgamations, not UserIDBundles.Neal H. Walfield
- Add the `UserID`, `UserIDAmalgamation` and `ValidUserIDAmalgamation` types, and some associated methods. - Replace the use of `UserIDBundle` with `UserIDAmalgamation` and `ValidUserIDAmalgamation`.
2020-04-02openpgp: Move the writer module to serialize::stream.Justus Winter
2020-04-02openpgp: Drop Fingerprint::from_hex in favor of FromStr.Justus Winter
- See #462.
2020-04-02openpgp: Drop KeyID::from_hex in favor of FromStr.Justus Winter
- See #462.
2020-03-31ffi: Move around UNIX-specifix importIgor Matuszewski
2020-03-27openpgp: Explain binding signature lookup failures.Justus Winter
- If looking up a binding signature fails, don't merely return None, but an Err(_) that explains the lookup failure. For example, a binding signature may be present, but it may not meet the policy. - Fixes #460.
2020-03-26Remove redundant field names.Wiktor Kwapisiewicz
2020-03-26openpgp: Have validated components return a validated cert.Neal H. Walfield
- Change ValidAmalgamation::cert to return a `&ValidCert` instead of a `Cert`. - Fixes #454.
2020-03-25openpgp: Improve performance of detached signature verification.Justus Winter
- Previously, we transformed data and detached signatures into signed messages on the fly, then used the streaming Verifier to verify the message. However, this introduces a nontrivial overhead, even if unnecessary copies are carefully avoided. - Instead, specialize the streaming Decryptor to handle detached signatures. use crypto::hash_buffered_reader to compute the hashes over the data, then attach the computed signatures to the signature packets, and use Decryptor's verification machinery. - While this is arguably less elegant, it is much simpler, and a lot faster. Notably, if we operate on files and can mmap them into memory, we can compute the hash in one call to the compression function. Verification of detached signatures is an important use case, so this speedup outweighs the loss of elegance. - Fixes #457.
2020-03-23openpgp-ffi: Add pgp_valid_key_amalgamation_with_policy.Neal H. Walfield
- Expose ValidKeyAmalgamation::with_policy in the C FFI.
2020-03-20openpgp: Add a function to set the expiry of subkeys using the FFI.Neal H. Walfield
- Expose `ValidKeyAmalgamation::set_expiration_time` to the C FFI.
2020-03-20openpgp-ffi: Change key iterator to return key amalgamations.Neal H. Walfield
- Introduce `KeyAmalgamation` and `ValidKeyAmalgamation` to the C FFI. - Change pgp_cert_key_iter_next and pgp_cert_valid_key_iter_next to return them instead of keys.
2020-03-20openpgp: Remove `to_hex` in KeyHandle, KeyID and Fingerprint.Wiktor Kwapisiewicz
- Replace all usages of `to_hex` with formatting string with :X specifier. - Fixes #456.
2020-03-18openpgp-ffi: Add pgp_cert_builder_set_creation_time.Neal H. Walfield
2020-03-13openpgp: Add a Null Policy.Neal H. Walfield
- Add a new Null Policy, which accepts everything.
2020-03-13openpgp: Change pgp_writer_stack_message to take a reference.Neal H. Walfield
- pgp_writer_stack_message should take a reference to the writer and not take ownership of the writer. - This is essential for the armor writer, which needs to be explicitly finalized.
2020-03-13openpgp-ffi: Add missing argument to pgp_cert_primary_user_id.Neal H. Walfield
- Make the reference time an argument to pgp_cert_primary_user_id.
2020-03-11openpgp-ffi: Avoid undefined behavior.Justus Winter
- Dropping a zeroed instant of that type is not safe as it contains references.
2020-03-09Switch from failure to anyhow.Justus Winter
- Use the anyhow crate instead of failure to implement the dynamic side of our error handling. anyhow::Error derefs to dyn std::error::Error, allowing better interoperability with other stdlib-based error handling libraries. - Fixes #444.
2020-03-09Reduce use of explicit failure::Fallible.Justus Winter
2020-03-03openpgp: Only impl Serialize for objects that are normally exported.Neal H. Walfield
- Add two new traits: `Marshal` and `MarshalInto`. - Implement them instead of `Serialize` and `SerializeInto`. - Only implement `Serialize` and `SerializeInto` for data structures that are normally exported. - This should prevent users from accidentally serializing a bare signature (`Signature`) when they meant to serialize a signature packet (`Packet`), for instance. - Fixes #368.
2020-02-27openpgp: Make KeyIter and ValidKeyIter generic over the key's role.Neal H. Walfield
2020-02-26openpgp: Complete the binding -> bundle rename.Neal H. Walfield
- Started in d183e12a3231e4c505f5f2cf48b6c1f881ad258a.
2020-02-26openpgp: Add a prelude file to import things related to certificatesNeal H. Walfield
- Add `openpgp/src/cert/prelude.rs` to import most types and traits related to certificates. - Use it instead of using the types and traits individually.
2020-02-24openpgp: Check critical notations against good-list.Justus Winter
- See #274.
2020-02-20openpgp: Split the ValidAmalgamation trait.Neal H. Walfield
- Split the ValidAmalgamation trait into two traits, Amalgamation and ValidAmalgamation, so that the functionality made available by the Amalgamation trait can be provided by a ComponentAmalgamation, which doesn't have a policy.
2020-02-20openpgp: Rename the Amalgamation trait to ValidAmalgamation.Neal H. Walfield
- The Amalgamation trait only applies to ValidComponents. Rename it accordingly.
2020-02-19openpgp: Move RevocationStatus to module types.Justus Winter
2020-02-19openpgp: Split VerificationResult.Justus Winter
- Split VerificationResult into Result<GoodChecksum, VerificationError>. - Fixes #416.
2020-02-17openpgp: Make Recipient::new polymorphic over key variants.Justus Winter
2020-02-12openpgp: Add optional cipher argument to DecryptionHelper::decrypt.Justus Winter
2020-02-12openpgp: Add optional cipher argument to PKESK3::decrypt.Justus Winter
2020-02-11openpgp: Use absolute expiration time in cert.Justus Winter
- The certificate is a mid-level interface, and should therefore use the more user-friendly way of specifying expiration. - Fixes #429.
2020-02-11openpgp: Call 'expiration time' a 'validity period'.Justus Winter
- The former is a misnomer inherited from the RFC: It is a duration, not a point in time. 'Validity period' makes that clear, and also emphasizes that the key or signature is valid during that period. - See #429.
2020-02-09openpgp: Add new error, PolicyViolation.Neal H. Walfield
2020-02-07openpgp: Rename Cert::set_expiry to set_expiration_time.Justus Winter
2020-02-06autocrypt: New crate.Justus Winter
- Move the autocrypt-related functionality to a new crate. - Fixes #424.
2020-02-06openpgp: Rename methods 'set_policy' to 'with_policy'.Justus Winter
- Fixes #427.
2020-02-06openpgp, openpgp-ffi, ipc: Add missing dyn.Justus Winter
2020-02-06openpgp: Expose all component-related types in cert::components.Justus Winter
2020-02-06openpgp: Rename ComponentBinding to ComponentBundle, etc.Justus Winter
- Likewise KeyBinding, UserIDBinding, UserAttributeBinding, UnknownBinding, etc. - Reason: a self-signature on a component is a binding, but revocations and TPSes are not bindings. - Consistently call collections of components and associated signatures bundles now. Likewise for fields, methods. - Fixes #425.
2020-02-05openpgp-ffi: Provide pgp_armor_writer_finalize.Justus Winter
2020-02-05openpgp-ffi: Specialize armor writers.Justus Winter
2020-01-31openpgp: Add a policy object.Neal H. Walfield
- Change all functions that need to evaluate the validity of a signature (either directly or indirectly to take a policy object. - Use the policy object to allow the user to place additional constraints on a signature's validity. - This addresses the first half of #274 (it introduces the policy object, but does not yet implement any policy).