| Age | Commit message (Collapse) | Author |
|---|
|
Instead of "return foo" as the last statement executed in a function,
just use "foo", which is more idiomatic style.
This was found by the clippy lint needless_return:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
|
|
Rust can automatically deduce lifetimes in some cases ("lifetime
elision"). While adding unnecessary lifetime annotations is not
incorrect, it can make it harder to follow the code: why is there a
lifetime annotation here? What is the reason why it's needed? Is
something unusual going on.
This removes a few unnecessary lifetime annotations, as found by the
clippy lint needless_lifetimes:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
|
The extra & in a pattern (match arm or if let) is unnecessary and only
makes the code harder to read. In most places it's enough to just
remove the & from the pattern, but in a few places a dereference (*)
needs to be added where the value captured in the pattern is used, as
removing the & changes the type of the captured value to be a
reference.
Overall, the changes are almost mechanical. Although the diff is huge,
it should be easy to read.
The clippy lint match_ref_pats warns about this. See:
https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
|
|
|
|
- Apply cargo intraconv.
|
|
- Fixes #742.
|
|
|
|
|
|
|
|
|
|
This fixes a build failure under Windows. It seems the two options
will only work at the crate level in the future so the compiler warns
about them now, and will fail build later. In CI, warnings seem to
fail the build already.
https://github.com/rust-lang/rust/issues/82730
https://doc.rust-lang.org/nightly/rustdoc/the-doc-attribute.html#at-the-crate-level
|
|
|
|
|
|
- Support for the GnuPG keybox format, based on keybox files created by
GnuPG 2.2.23 and the way they are handled by the `kbxutil` program from
that version of GnuPG.
- Most structures that are not related to accessing the OpenPGP certs are
not handled, like X.509 records and metadata sections.
- Closes #252
|
|
|
|
See relevant MR on sequoia-octopus-lib:
https://gitlab.com/sequoia-pgp/sequoia-octopus-librnp/-/merge_requests/42
|
|
- This is d4876e3aa5bf1ce7d35431a632ec20ce23f2d1be in the octopus
repository.
|
|
- The libtest benchmark harness that is automatically added by cargo
interferes with criterion. Disable it everywhere where there are no
benchmarks.
- https://github.com/rust-lang/rust/issues/47241
- https://bheisler.github.io/criterion.rs/book/faq.html
|
|
Having the license file in the root directory is not enough, since
cargo actions for workspace members will not consider this file.
This commit adds a symbolic link to the license file in the root
directory of all workspace members, so "cargo publish" will include
the LICENSE.txt file when publishing crates.
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
- https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
|
|
- Constants have by default a `'static` lifetime
- https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
- https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
|
|
|
|
- This causes issues when dependencies are merged as rand 0.8 has more
granular feature selection and at least `std` should be used there.
|
|
- This moves all functionality from sequoia_core crate as an inner
`core` module of the ipc crate.
- The `core` module has to be public as other crates depend on
`core::Context` either directly (store, ffi) or indirectly (store
through ffi crate).
- Remove the `core` crate completely.
|
|
- Rewrite any `expect`s and `unwrap`s into the `?` operator.
- This loses the error detail. It could be recovered using `context`
but for simplicity sake of the example the `?` operator suffices.
- Additionally the `crate::` prefix has been removed as it is not
necessary.
|
|
- Previously the armor::Writer was used but this caused the armoring
not to be finalized and the output to appear truncated.
- Migrate to Armorer to fix the resulting output.
|
|
|
|
|
|
|
|
- Release buffered-reader 1.0.0, sequoia-openpgp 1.0.0, and
sequoia-sqv 1.0.0.
- Also release sequoia-sop 0.22.0.
|
|
- Fixes #630.
|
|
|
|
- Relaxes those dependencies that were unnecessarily strict and
patched by debian.
|
|
- Versions required by feature or API usage:
- anyhow 1.0.18.
- policy::test::reject_seip_packet and
policy::test::reject_cipher' fail
- We use `impl From<anyhow::Error> for Box<dyn std::error::Error +
Send + Sync + 'static>`, introduced in 1.0.5.
- tokio 0.2.19
- We use `tokio::net::tcp::OwnedReadHalf`, introduced in 0.2.19.
- chrono 0.4.10
- We use the `std` feature, introduced in 0.4.10.
- thiserror 1.0.2
- futures and futures-util 0.3.5
- tempfile 3.1
- c_doctests require the same version of rand both as direct
dependency and through tempfile.
- Yanked versions:
- structopt 0.3.11. 0.3.8 to 0.3.10 were yanked.
- socket2 0.3.16. 0.3.0 to 0.3.15 were yanked.
- Update our dependencies to the package versions required by other
dependencies, e.g. structopt requires lazy_static 1.4.0.
- clap 2.33
- lazy_static to 1.4.0
- libc to 0.2.66
- proc-macro2 to 1.0.7
- syn to 1.0.5.
- winapi 0.3.8
|
|
- This way the entire `BufferedReader<C>` will be `Send` and `Sync`.
- Modify all other crates accordingly.
- See #615.
|
|
|
|
- Serialize and Marshal have certain guarentees
such as not exporting non-exportable Signatures.
- In addition Serialize should only be implemented
for standardized data structures.
- We are also pondering adding `to_armored` functionality for serialized data.
This does not really work with the ipc data structures.
- Ipc provides serialization - but not the kind of serialization
the openpgp crate is talking about.
Plus we are considering sealing the traits.
|
|
|
|
|
|
- Fixes #563
- With an MSRV >= 1.40.0, we can use #[non_exhaustive], as mentioned
in #406.
- This is also a clippy lint:
https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
|
|
|
|
|
|
|
|
Almost every Windows path contains a (percent-encoded) colon coupled
with a drive letter (e.g. C:), so this needs to be done to properly decode
a path.
|
|
|
