Age | Commit message (Collapse) | Author |
|
|
|
This will let `sq` not depend on `clap` version 2, even transitively.
Sponsored-by: pep.foundation
|
|
- When the decryptor returns a short session key without reporting
an error, an overflow occurs. Avoid this by using saturating
subtraction. Then, the resulting range is empty, and an error
will be reported just a few lines down.
- Fixes #913.
|
|
This is the most conservative possible relaxation of the dependency,
and it makes the tool buildable on debian stable, where serde_json is
currently blocked by a confusing mess (https://bugs.debian.org/1015743)
I suspect it could be relaxed even further (best would be serde_json =
"1"), but i haven't tested it against serde 1.0.0, and this change is
sufficient for my purposes for now.
|
|
This allows the user to query what output versions are available and
what is the current default one.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
This makes it easier to manage them in one place. Also, allows one
place where the output model version is picked.
Also add integration tests to sq-subplot.md.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
The JSON is the same same for both subcommands on the assumption that
if someone is consuming JSON, they will pick the field relevant to
them in any case. For someone consuming the default output format,
they choose by using the right subcommand and don't have to parse the
output.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
|
|
- Use clap-provided mechanisms instead of manually parsing --help
output.
- Fixes #872.
|
|
|
|
- This is more intuitive instead of fiddling with display_order
numbers.
- Allows iterating over the subcommands in the order they are
displayed.
|
|
- Remove the workaround that was required to include help output in
docs.
|
|
|
|
SQ_OUTPUT_FORMAT and SQ_OUTPUT_VERSION will be obeyed unless the
corresponding options are used.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
Sponsored-by: NLnet Foundation; NGI Assure
|
|
This heavily changes the subcommand implementation. The original code
mixed concerns (iterating over certificates, making decisions about
primary UserID, and formatting output). This changes things so that
the concerns are more separate.
Formatting of JSON output is done using the serde_json crate. This
makes it easy to add other formats supported by serde later.
Unfortunately, using serde means the whole parsed keyring must be kept
in memory at once, because serde doesn't know how to serialize an
iterator: a serde serializer gets an immutable reference to the data
being serialized, and an iterator must be mutable. We may need
to fix that later, but all my attempts to do so failed.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
These aren't used yet, this is preparation for future changes.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
Nothing implements these yet, this is preparation for future changes.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
These are not yet used, this is preparation for future changes.
Sponsored-by: NLnet Foundation; NGI Assure
|
|
- The manpages have been generated with the nora/clap3-man branch.
- We needed to fork clap to
- add the SEE ALSO section
- rename the EXTRA section to EXAMPLES
- display possible values (upstream issue
https://github.com/clap-rs/clap/issues/3861)
- Hide the help subcommand from the subcommands list
We will work with upstream to provide the required functionality, so
we can use upstream clap again.
|
|
|
|
|
|
|
|
- When a dash occurs outside of a range, it should be considered an
atom.
- Fixes #897.
|
|
- The network policy argument of sq wkd and sq keyserver is --policy
or -p, leading to possible confusion with sequoia's openpgp policy.
- Rename the argument to --network-policy and -n.
|
|
|
|
|
|
|
|
|
|
- Reading certs and secret keys is handled the same way by all revoke
functions.
|
|
|
|
- The different subcommands for sq revoke are very similar, they have
many arguments in common. Previously, they were handled together in
one functions. Now, as each subcommand is represented by
a different struct, this had to be split up.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- WkdNetworkPolicy and KeyserverPolicy have the same variants and both
are parsed to sequoia_net::Policy. Unify and rename to
NetworkPolicy.
|
|
- The handling code for sq wkd get expects an "output" argument, but
that argument was not defined.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- The handling function of sq key generate treats the --export
argument as optional.
- Reflect that in the argument definition.
|
|
|
|
|