diff options
author | Neal H. Walfield <neal@pep.foundation> | 2017-12-11 22:36:15 +0100 |
---|---|---|
committer | Neal H. Walfield <neal@pep.foundation> | 2017-12-11 22:36:15 +0100 |
commit | 9d3a45d60f7a7700c85912c09951a64584fc7b41 (patch) | |
tree | 4d11763c937ee84755468bdea037a130b8927932 /src | |
parent | 600b3e806ff378f5bf2dab4cf594418056d2d0c0 (diff) |
Remove some redundant code.
Diffstat (limited to 'src')
-rw-r--r-- | src/openpgp/parse/parse.rs | 33 |
1 files changed, 12 insertions, 21 deletions
diff --git a/src/openpgp/parse/parse.rs b/src/openpgp/parse/parse.rs index 024c1f7b..2c9f3192 100644 --- a/src/openpgp/parse/parse.rs +++ b/src/openpgp/parse/parse.rs @@ -798,7 +798,7 @@ impl Message { let mut pp = ppo.unwrap(); 'outer: loop { - let (packet, ppo, relative_position2) = pp.recurse()?; + let (mut packet, mut ppo, mut relative_position2) = pp.recurse()?; assert!(-depth <= relative_position); assert!(relative_position <= 1); @@ -822,31 +822,13 @@ impl Message { } } - if relative_position > 0 { - // Create a new container. - let tmp = container; - let i = tmp.packets.len() - 1; - assert!(tmp.packets[i].children.is_none()); - tmp.packets[i].children = Some(Container::new()); - container = tmp.packets[i].children.as_mut().unwrap(); - } - - container.packets.push(packet); - - if ppo.is_none() { - break 'outer; - } - - relative_position = relative_position2; - pp = ppo.unwrap(); // If next packet will be inserted in the same container // or the current container's child, we don't need to walk // the tree from the root. - while relative_position >= 0 { - let (packet, ppo, relative_position2) = pp.recurse()?; - + loop { if relative_position == 1 { + // Create a new container. let tmp = container; let i = tmp.packets.len() - 1; assert!(tmp.packets[i].children.is_none()); @@ -862,6 +844,15 @@ impl Message { relative_position = relative_position2; pp = ppo.unwrap(); + + if relative_position < 0 { + break; + } + + let result = pp.recurse()?; + packet = result.0; + ppo = result.1; + relative_position2 = result.2; } } |