diff options
| author | Azul <azul@riseup.net> | 2020-11-28 10:20:37 +0100 |
|---|---|---|
| committer | Azul <azul@riseup.net> | 2020-12-01 16:23:26 +0100 |
| commit | 5c0cd1775fadc46e68a24a5af3d1f06803d69c4b (patch) | |
| tree | 27c9006288e21b2893258e7d7123894d1b8b8af3 /sqv | |
| parent | d40cd05ece363d49fad83f0d37b7f7a01090a585 (diff) | |
openpgp: take ownership of KeyFlags bitfield
- Make `generate_key` polymorphic over `AsRef<KeyFlags>`.
- Since `set_key_flags` requires ownership of the key flags, it should
take ownership rather than borrowing and cloning the them.
See https://rust-lang.github.io/api-guidelines/flexibility.html#caller-decides-where-to-copy-and-place-data-c-caller-control .
- See #616.
Diffstat (limited to 'sqv')
| -rw-r--r-- | sqv/tests/revoked-key.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sqv/tests/revoked-key.rs b/sqv/tests/revoked-key.rs index 404092e1..fcc35f4f 100644 --- a/sqv/tests/revoked-key.rs +++ b/sqv/tests/revoked-key.rs @@ -315,7 +315,7 @@ fn create_key() { // 1st direct key signature valid from t1 on let mut b = signature::SignatureBuilder::new(SignatureType::DirectKey) .set_features(&Features::sequoia()).unwrap() - .set_key_flags(&KeyFlags::empty() + .set_key_flags(KeyFlags::empty() .set_signing().set_certification()).unwrap() .set_signature_creation_time(t1).unwrap() .set_preferred_hash_algorithms(vec![HashAlgorithm::SHA512]) @@ -324,7 +324,7 @@ fn create_key() { // 1st subkey binding signature valid from t_sk_binding on b = signature::SignatureBuilder::new(SignatureType::SubkeyBinding) - .set_key_flags(&KeyFlags::empty().set_signing()).unwrap() + .set_key_flags(KeyFlags::empty().set_signing()).unwrap() .set_signature_creation_time(t_sk_binding).unwrap() .set_embedded_signature( signature::SignatureBuilder::new(SignatureType::PrimaryKeyBinding) @@ -336,7 +336,7 @@ fn create_key() { // 2nd direct key signature valid from t3 on b = signature::SignatureBuilder::new(SignatureType::DirectKey) .set_features(&Features::sequoia()).unwrap() - .set_key_flags(&KeyFlags::empty() + .set_key_flags(KeyFlags::empty() .set_signing().set_certification()).unwrap() .set_signature_creation_time(t3).unwrap() .set_preferred_hash_algorithms(vec![HashAlgorithm::SHA512]) @@ -345,7 +345,7 @@ fn create_key() { // 2nd subkey binding signature valid from t3 on let mut b = signature::SignatureBuilder::new(SignatureType::SubkeyBinding) - .set_key_flags(&KeyFlags::empty().set_signing()).unwrap() + .set_key_flags(KeyFlags::empty().set_signing()).unwrap() .set_signature_creation_time(t3).unwrap() .set_embedded_signature( signature::SignatureBuilder::new(SignatureType::PrimaryKeyBinding) |